Skip to content

Conversation

@gputnam
Copy link
Contributor

@gputnam gputnam commented Jun 2, 2025

Collecting fixes and needed updates here:
-Use correct bad channel database tag
-Disable pulse train to prevent Pandora crashes at stage1

#827 is also needed.

@leoaliaga
Copy link
Contributor

trigger build larsoft@v10_06_00 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbnalg@v10_06_00_01 SBNSoftware/sbncode@v10_06_00_01

@leoaliaga leoaliaga requested review from SFBayLaser and jzennamo June 17, 2025 14:37
@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@SFBayLaser
Copy link
Contributor

I am not aware that the proposed change to "long hits" has been fully vetted and approved. For example, have both the pandora and SPINE folks looked at the impact to the output of their respective reconstructions and signed off?

This potentially has a major impact to the reconstruction for particular categories of tracks. While nobody has ever said this scheme was perfect it is currently the known devil and I have not seen anything showing either no impact to reconstruction or improvement. So far as I know it solves a computation problem for one track in one event in the single failing job amongst several.

Copy link
Contributor

@SFBayLaser SFBayLaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said, I am uncomfortable with the changes to how "long hits" are handled but have been assured that this can be easily rectified in future processing. On the assumption that this will be studied in more detail I will approve.

I see no problem with the version change to the channel status DB.

@leoaliaga leoaliaga merged commit 2aaa6cc into develop Jun 18, 2025
2 of 4 checks passed
@leoaliaga leoaliaga deleted the feature/gputnam-patch-25Adata-production branch June 18, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants