-
Notifications
You must be signed in to change notification settings - Fork 40
Patches to 2025A Data Production #831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
trigger build larsoft@v10_06_00 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbnalg@v10_06_00_01 SBNSoftware/sbncode@v10_06_00_01 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
I am not aware that the proposed change to "long hits" has been fully vetted and approved. For example, have both the pandora and SPINE folks looked at the impact to the output of their respective reconstructions and signed off? This potentially has a major impact to the reconstruction for particular categories of tracks. While nobody has ever said this scheme was perfect it is currently the known devil and I have not seen anything showing either no impact to reconstruction or improvement. So far as I know it solves a computation problem for one track in one event in the single failing job amongst several. |
SFBayLaser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said, I am uncomfortable with the changes to how "long hits" are handled but have been assured that this can be easily rectified in future processing. On the assumption that this will be studied in more detail I will approve.
I see no problem with the version change to the channel status DB.
Collecting fixes and needed updates here:
-Use correct bad channel database tag
-Disable pulse train to prevent Pandora crashes at stage1
#827 is also needed.