Feature/howard for numi2023a from gputnam configs #431

brucehoward-physics · 2024-02-18T17:47:26Z

Cherry-picking in what I think are the relevant commits from Gray's feature branch used in the reprocessing.

A few minor edits where necessary to resolve a cherry-pick conflict may be present.

NOTES

FROM SBNCODE, pulling in Gray’s updates that took one from v09_72_00_03 -> feature/gputnam-configs EXCEPT:

The various merge commits themselves
The commits related to JZennamo and JLarkin features which only changed BeamRetriever (those should already be on the _06 release…)
The commits related to JKim feature which is included in another PR made against 2023A_NuMI: Also skipping e2a5cd8 which just updates systematicstools and nusystematics versions
The other merge on this feature is the following, which seems to bring in g4 (should compare to what’s in that issue marked elsewhere):

commit 7a40e9e
Merge: cbc6213 192a028
Author: gputnam {redacted}
Date: Sat Oct 21 20:47:52 2023 -0500

Merge branch 'gray_g4rwgt' into feature/gputnam-configs

The updated set captures the changes on top of the original v09_72_00_03 including g4 stuff, bumping sbndata up to v01_05, stub change, MCS updates, MeV Prtl stuff, calibration ntuples thing, using the T0s info when possible (I think for cosmics IIRC, update by Guadalupe in Gray’s area), filling trigger info… NOTE: the trigger info commit says “Allow time shift in trigger to IFBeam timing. Skip first event in stream in each run.” —> However, this commit seems to just add some extra fields getting filled in the CAFs more than changing anything. :

CMakeLists.txt
fcl/caf/cafmaker_common_defs.fcl
sbncode/CAFMaker/CAFMaker_module.cc
sbncode/CAFMaker/FillTrigger.cxx
sbncode/Calibration/TrackCaloSkimmer_module.cc
sbncode/EventGenerator/MeVPrtl/Tools/ALP/Meson2ALP_tool.cc
sbncode/LArRecoProducer/LArReco/TrajectoryMCSFitter.cxx
sbncode/LArRecoProducer/LArReco/TrajectoryMCSFitter.h
sbncode/LArRecoProducer/mcsproducer.fcl
sbncode/LArRecoProducer/mcsproducer_icarus.fcl
sbncode/SBNEventWeight/App/CMakeLists.txt
sbncode/SBNEventWeight/CMakeLists.txt
sbncode/SBNEventWeight/Calculators/CMakeLists.txt
sbncode/SBNEventWeight/Calculators/Geant4/BetheBlochForG4ReweightValid.h
sbncode/SBNEventWeight/Calculators/Geant4/CMakeLists.txt
sbncode/SBNEventWeight/Calculators/Geant4/Geant4WeightCalc.cxx
sbncode/SBNEventWeight/jobs/CMakeLists.txt
sbncode/SBNEventWeight/jobs/geant4/CMakeLists.txt
sbncode/SBNEventWeight/jobs/geant4/eventweight_geant4_sbn.fcl
sbncode/SBNEventWeight/jobs/geant4/piminus_reweight_parameters.fcl
sbncode/SBNEventWeight/jobs/geant4/piplus_reweight_parameters.fcl
sbncode/SBNEventWeight/jobs/geant4/proton_reweight_parameters.fcl
sbncode/TPCReco/VertexStub/config/sbn_stub_merge_tools.fcl
ups/product_deps

…ader

…te_v09_72_00_03

SBNEventWeight differences. Also make some adjustments to get it to build against geant4reweight v01_00_03e -q e20:s117:prof

* Placeholder for sampled parameter storage, for CAF compatibility. * Renamed fcl for consistency

…calorimetry variables

…eam in each run.

…pdate_v09_72_00_03' into feature/howard_forNuMI2023A_from_gputnam-configs

brucehoward-physics · 2024-02-19T20:20:47Z

Merged Jaesung's feature branch into this -- this will facilitate testing and makes it slightly easier/fewer things.

…mInCAFsForG4Study_v09_72_00_06' into feature/howard_forNuMI2023A_from_gputnam-configs

brucehoward-physics · 2024-02-19T20:27:41Z

And merged Jaesung's saving of all true particles from the interaction in interaction truth not just the main primaries to G4...

brucehoward-physics · 2024-03-22T16:51:58Z

sbncode/CAFMaker/FillTrue.cxx

+        //if(part.start_process == caf::kG4primary) srneutrino.prim.push_back(part);
+        // Feb. 15th 2024, Jaesung Kim: Saving non-primaries for G4Reweight study
+        srneutrino.prim.push_back(part);


I approve this change :)

Thank you, @brucehoward-physics.
Isn't this going to add on every neutrino event the whole GEANT4 history of particles, from the lepton the neutrino turned into down to the last electron of a showering pion?

PetrilloAtWork

I am not sure the question about the dependency version was sorted, but I let that to the release managers, since I am sure I don't know all it's needed to positively contribute.
The rest is good, provided that it stays in special branches (I am thinking mostly of the potential increase in CAF data volume, which we would need to discuss before bringing to the generic production).

miquelnebot · 2024-05-22T14:56:00Z

trigger build

FNALbuild · 2024-05-22T14:59:27Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2024-05-22T14:59:27Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2024-05-22T15:00:20Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2024-05-22T15:00:26Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2024-05-22T15:00:29Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2024-05-22T15:00:33Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2024-05-22T22:36:34Z

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

FNALbuild · 2024-05-22T22:57:45Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2024-05-22T22:59:39Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

brucehoward-physics · 2024-05-22T23:56:23Z

Sorry for the complexity here @miquelnebot :( -- This will depend on

SBNSoftware/sbnobj#105 (Calo Skimmer stuff)

as well as

SBNSoftware/sbnanaobj#126 (SRTrigger updates)

FNALbuild · 2024-05-23T10:20:50Z

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

FNALbuild · 2024-05-23T10:39:49Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2024-05-23T10:42:49Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2024-05-23T15:40:03Z

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

FNALbuild · 2024-05-23T15:53:06Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2024-05-23T15:59:33Z

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2024-05-23T22:20:03Z

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

FNALbuild · 2024-05-23T22:37:20Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2024-05-23T22:57:11Z

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2024-05-24T08:51:30Z

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

FNALbuild · 2024-05-24T09:05:03Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2024-05-24T09:19:04Z

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2024-05-26T22:37:15Z

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

FNALbuild · 2024-05-26T22:46:52Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2024-05-26T23:00:38Z

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

jedori0228 and others added 20 commits June 2, 2023 12:25

Update SystToolsEventWeight for dependent dials

706c4d8

Duplicated declaration of fParameterSet removed

f0c3c49

Update logger for SystToolsEventWeight_module.cc

12aa749

Update SystToolsEventWeight module to treat isCorrection=true paramhe…

58c6946

…ader

Saving non primaries to nu.prim for G4 study

fd58a14

Update systematicstools/nusystematics versions

43893b9

Merge branch 'release/SBN2023A_NuMI' into feature/jskim_SystToolsUpda…

7ba8ce5

…te_v09_72_00_03

Add the MicroBooNE weight calculator that interfaces with geant4reweight

658fb3b

Some tweaks to adjust for larsim EventWeight (used by uB) vs.

1f3c410

SBNEventWeight differences. Also make some adjustments to get it to build against geant4reweight v01_00_03e -q e20:s117:prof

geant4reweight interface updates + generic sbn fcls

38da527

g4reweight bugfix and temporary parameter storage

ce8b26c

* Placeholder for sampled parameter storage, for CAF compatibility. * Renamed fcl for consistency

Fill true trajectory points.

dc8fffd

Disable cross-plane stub merging.

53c9ee9

For cosmics that are crossing the cathode we added T0 information in …

2eebbe0

…calorimetry variables

exclude region feature

5dd9140

restructure, skip out of fv hits

b7657b3

Allow time shift in trigger to IFBeam timing. Skip first event in str…

2dbf3b3

…eam in each run.

Update sbndata

79920dd

Include Geant4 libraries for buiding

782e10c

Fix ALP mass suppression.

2591aa1

This was linked to issues Feb 18, 2024

NuMI XSec 2024 Updated Production Patch: Updated MCS #428

Open

NuMI XSec 2024 Analysis: Geant4Reweight old release availability with an e20 build #424

Open

Merge remote-tracking branch 'remotes/origin/feature/jskim_SystToolsU…

6b24a02

…pdate_v09_72_00_03' into feature/howard_forNuMI2023A_from_gputnam-configs

Merge remote-tracking branch 'remotes/origin/feature/jskim_SaveNonPri…

c0ca4a5

…mInCAFsForG4Study_v09_72_00_06' into feature/howard_forNuMI2023A_from_gputnam-configs

brucehoward-physics requested a review from gputnam February 23, 2024 19:10

brucehoward-physics mentioned this pull request Feb 23, 2024

Saving non-primaries in cafs for g4 study [release/SBN2023A_NuMI] #429

Merged

gputnam mentioned this pull request Feb 26, 2024

Update Calibration of MCS for ICARUS #439

Merged

brucehoward-physics commented Mar 22, 2024

View reviewed changes

PetrilloAtWork approved these changes May 21, 2024

View reviewed changes

brucehoward-physics mentioned this pull request May 23, 2024

Feature/howard for dev incorporate gputnam trigger product change #467

Merged

miquelnebot merged commit 8bb61c5 into release/SBN2023A_NuMI May 27, 2024

jedori0228 mentioned this pull request Jun 21, 2024

Updating SystTool module for Dependent dials [release/SBN2023A_NuMI] #423

Closed

Feature/howard for numi2023a from gputnam configs #431

Feature/howard for numi2023a from gputnam configs #431

Uh oh!

Conversation

brucehoward-physics commented Feb 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brucehoward-physics commented Feb 19, 2024

Uh oh!

brucehoward-physics commented Feb 19, 2024

Uh oh!

brucehoward-physics Mar 22, 2024

Choose a reason for hiding this comment

Uh oh!

PetrilloAtWork May 2, 2024

Choose a reason for hiding this comment

Uh oh!

PetrilloAtWork left a comment

Choose a reason for hiding this comment

Uh oh!

miquelnebot commented May 22, 2024

Uh oh!

FNALbuild commented May 22, 2024

Uh oh!

FNALbuild commented May 22, 2024

Uh oh!

FNALbuild commented May 22, 2024

Uh oh!

FNALbuild commented May 22, 2024

Uh oh!

FNALbuild commented May 22, 2024

Uh oh!

FNALbuild commented May 22, 2024

Uh oh!

FNALbuild commented May 22, 2024

Uh oh!

FNALbuild commented May 22, 2024

Uh oh!

FNALbuild commented May 22, 2024

Uh oh!

brucehoward-physics commented May 22, 2024

Uh oh!

FNALbuild commented May 23, 2024

Uh oh!

FNALbuild commented May 23, 2024

Uh oh!

FNALbuild commented May 23, 2024

Uh oh!

FNALbuild commented May 23, 2024

Uh oh!

FNALbuild commented May 23, 2024

Uh oh!

FNALbuild commented May 23, 2024

Uh oh!

FNALbuild commented May 23, 2024

Uh oh!

FNALbuild commented May 23, 2024

Uh oh!

FNALbuild commented May 23, 2024

Uh oh!

FNALbuild commented May 24, 2024

Uh oh!

FNALbuild commented May 24, 2024

Uh oh!

FNALbuild commented May 24, 2024

Uh oh!

FNALbuild commented May 26, 2024

Uh oh!

FNALbuild commented May 26, 2024

Uh oh!

FNALbuild commented May 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

brucehoward-physics commented Feb 18, 2024 •

edited

Loading