Skip to content

Modify MergeSimChannels signature with check to skip G4 tracks or not #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kjplows merged 3 commits into from
Apr 18, 2025
Merged

Modify MergeSimChannels signature with check to skip G4 tracks or not #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e6df76
update signature with fSkipSimChannelTrackIDs (default false)
kjplows Apr 17, 2025
d29a41c
fix the bool
kjplows Apr 17, 2025
59f21ed
please let me run the CI
kjplows Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion sbncode/LArG4/MergeSimSourcesSBN_module.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,12 @@ class sbn::MergeSimSourcesSBN : public art::EDProducer {
true // default
};

fhicl::Atom<bool> SkipSimChannelTrackIDs{
fhicl::Name{"SkipSimChannelTrackIDs"},
fhicl::Comment{"Skip G4 track IDs in SimChannels"},
false // default
};

fhicl::Atom<bool> FillAuxDetSimChannels{
fhicl::Name{"FillAuxDetSimChannels"},
fhicl::Comment{"whether to merge AuxDetSimChannels"},
Expand Down Expand Up @@ -156,6 +162,7 @@ class sbn::MergeSimSourcesSBN : public art::EDProducer {
bool const fFillMCParticlesAssociated;
bool const fFillSimPhotons;
bool const fFillSimChannels;
bool const fSkipSimChannelTrackIDs;
bool const fFillAuxDetSimChannels;
bool const fFillSimEnergyDeposits;
std::vector<std::string> const fEnergyDepositionInstances;
Expand Down Expand Up @@ -198,6 +205,7 @@ sbn::MergeSimSourcesSBN::MergeSimSourcesSBN(Parameters const& params)
, fFillMCParticlesAssociated(params().FillMCParticlesAssociated())
, fFillSimPhotons(params().FillSimPhotons())
, fFillSimChannels(params().FillSimChannels())
, fSkipSimChannelTrackIDs(params().SkipSimChannelTrackIDs())
, fFillAuxDetSimChannels(params().FillAuxDetSimChannels())
, fFillSimEnergyDeposits(
getOptionalValue(params().FillSimEnergyDeposits)
Expand Down Expand Up @@ -349,7 +357,7 @@ void sbn::MergeSimSourcesSBN::produce(art::Event& e)

if (fFillSimChannels) {
auto const& input_scCol = e.getProduct<std::vector<sim::SimChannel>>(input_label);
MergeUtility.MergeSimChannels(*scCol, input_scCol, i_source);
MergeUtility.MergeSimChannels(*scCol, input_scCol, i_source, fSkipSimChannelTrackIDs);
}

if (fFillAuxDetSimChannels) {
Expand Down Expand Up @@ -451,6 +459,7 @@ void sbn::MergeSimSourcesSBN::dumpConfiguration() const
if (fFillMCParticlesAssociated) log << "\n - filling MCParticlesAssociated";

if (fFillSimChannels) log << "\n - filling SimChannels";
if (fSkipSimChannelTrackIDs) log << "\n - skipping track IDs in filling SimChannels";

if (fFillAuxDetSimChannels) log << "\n - filling AuxDetSimChannels";

Expand Down
4 changes: 2 additions & 2 deletions ups/product_deps
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,12 +254,12 @@ libdir fq_dir lib
product version qual flags <table_format=2>
genie_xsec v3_04_00 -
larcv2 v2_2_6 -
larsoft v10_04_08 -
larsoft v10_05_00 -
sbnalg v10_04_08 -
sbndaq_artdaq_core v1_10_06 -
sbndata v01_07 -
systematicstools v01_04_04 -
nusystematics v1_05_06 -
nusystematics v1_05_07 -
cetmodules v3_24_01 - only_for_build
end_product_list
####################################
Expand Down