Skip to content

Conversation

@gputnam
Copy link
Contributor

@gputnam gputnam commented Apr 30, 2025

Fixes bug in ChannelROI to Wire (back-)conversion introduced in #535.

@gputnam gputnam requested a review from SFBayLaser April 30, 2025 21:34
Copy link
Contributor

@SFBayLaser SFBayLaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, obvious Faux Pas which is fixed here.

@kjplows
Copy link
Contributor

kjplows commented May 1, 2025

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_05_00

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Testing to To merge in SBN software development May 1, 2025
@kjplows kjplows merged commit ac0dda7 into develop May 1, 2025
3 of 6 checks passed
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development May 1, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development May 1, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants