-
Notifications
You must be signed in to change notification settings - Fork 35
Ensure CRT T0 usage in calibration ntuples is direction aware #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
linyan-w
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A big thank you to Henry! You are the hero!
|
trigger build LArSoft/larsoft@LARSOFT_SUITE_v10_06_00_02 LArSoft/larwirecell@LARSOFT_SUITE_v10_06_00_02 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
SBND CI is successful, merging! Many thanks @henrylay97 |
Description
This PR fixes a bug in how the calib ntuples make use of the CRT track T0 tagging. There was no accounting for the fact that the drift direction is different in the two TPCs so the xshift has to be in different directions depending on which TPC is being considered.
Please see slides linked investigating the issue: https://docs.google.com/presentation/d/1CJ8yL7P7Dae1H3r_99cGIuQ4Dqgc2nATDqnGpyKvbaE/edit?usp=sharing
I haven't presented these slides because a hotfix was requested. I can present them at a future calibration meeting. The key plots are shown below. They show the TPC track start in x for tracks that have been shifted by the CRT T0 values.
Before Fix
After Fix