Skip to content

Conversation

@henrylay97
Copy link
Member

@henrylay97 henrylay97 commented Jul 25, 2025

Description

This PR fixes a bug in how the calib ntuples make use of the CRT track T0 tagging. There was no accounting for the fact that the drift direction is different in the two TPCs so the xshift has to be in different directions depending on which TPC is being considered.

Please see slides linked investigating the issue: https://docs.google.com/presentation/d/1CJ8yL7P7Dae1H3r_99cGIuQ4Dqgc2nATDqnGpyKvbaE/edit?usp=sharing

I haven't presented these slides because a hotfix was requested. I can present them at a future calibration meeting. The key plots are shown below. They show the TPC track start in x for tracks that have been shifted by the CRT T0 values.

Before Fix

tpc_start_x_crt_t0

After Fix

tpc_start_x_crt_t0
  • Have you added a label? (bug/enhancement/physics etc.)
  • Have you assigned at least 1 reviewer?
  • Is this PR related to an open issue / project?
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.
  • Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.
  • Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

@henrylay97 henrylay97 self-assigned this Jul 25, 2025
@henrylay97 henrylay97 added the bugfix Addresses one or more bugs label Jul 25, 2025
Copy link
Contributor

@linyan-w linyan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A big thank you to Henry! You are the hero!

@kjplows
Copy link
Contributor

kjplows commented Jul 30, 2025

trigger build LArSoft/larsoft@LARSOFT_SUITE_v10_06_00_02 LArSoft/larwirecell@LARSOFT_SUITE_v10_06_00_02 LArSoft/lar*@LARSOFT_SUITE_v10_06_00

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@kjplows
Copy link
Contributor

kjplows commented Jul 30, 2025

SBND CI is successful, merging! Many thanks @henrylay97

@kjplows kjplows moved this from Testing to To merge in SBN software development Jul 30, 2025
@kjplows kjplows merged commit 8268d88 into develop Jul 30, 2025
4 of 7 checks passed
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Jul 30, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Jul 30, 2025
@linyan-w linyan-w moved this from Approved to To be merged in SBND 2025 Fall Production Jul 31, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Aug 9, 2025
@asanchezcastillo asanchezcastillo moved this from To be merged to Approved in SBND 2025 Fall Production Aug 11, 2025
@asanchezcastillo asanchezcastillo moved this from Approved to To be merged in SBND 2025 Fall Production Aug 11, 2025
@linyan-w linyan-w moved this from To be merged to In tagged release in SBND 2025 Fall Production Aug 19, 2025
@kjplows kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026
@github-project-automation github-project-automation bot moved this from Todo to Done in PR archaeology Jan 16, 2026
@kjplows kjplows added this to the SBN2025A/v10_06_00_04 milestone Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Addresses one or more bugs

Projects

Status: Done
Status: 2025 PRs
Status: In tagged release

Development

Successfully merging this pull request may close these issues.

6 participants