Geant4Reweight SBN/SBND implementation #554
Conversation
SBNEventWeight differences. Also make some adjustments to get it to build against geant4reweight v01_00_03e -q e20:s120a:prof
* Placeholder for sampled parameter storage, for CAF compatibility. * Renamed fcl for consistency
…nto one, successfully compiled
…rticle type at time
…rw_91_02_01' into feature/pgreen_g4rw
…in geant4reweight
afropapp13
left a comment
afropapp13
left a comment
There was a problem hiding this comment.
Happy to merge if there are no conflicts
|
The feature branch is out-of-date with base but given production only had a couple of small updates that are not G4-related it should not affect this PR. Can you please quickly check if it's OK @pgreen135 ? Thanks |
|
trigger build LArSoft/larsoft@LARSOFT_SUITE_v10_06_00_02 LArSoft/larwirecell@LARSOFT_SUITE_v10_06_00_02 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbndata#9 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
trigger build LArSoft/larsoft@LARSOFT_SUITE_v10_06_00_02 LArSoft/larwirecell@LARSOFT_SUITE_v10_06_00_02 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbndata#9 SBNSoftware/sbn*@release/SBN2025A |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
kjplows
left a comment
kjplows
left a comment
There was a problem hiding this comment.
The ICARUS CI test failures are known (related to fcl files needing to be updated). Most of SBND CI tests pass, warnings look innocuous. If @lyates17 and @JackSmedley are happy with this PR this is good to merge.
kjplows
moved this from Open pull requests
to Partially reviewed
in SBN software development
Looks fine to me, thanks |
github-project-automation
bot
moved this from To merge
to Done
in SBN software development
7 participants
This PR adds in Geant4Reweight SBN implementation for use in SBND. Code modernised version of MicroBooNE implementation, written by @JackSmedley.
Tested for SBND, see DocDB: https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=42747
Needs merging into both production release and into develop.
To be merged with corresponding PRs: