Skip to content

Conversation

@gputnam
Copy link
Contributor

@gputnam gputnam commented Sep 15, 2025

This module extends the CORSIKA gen module to filter on muons to get a sample enriched in those that cross either a configured set of CRT planes, or the cathode.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRT Y0 and CRT Y1 being the same (618 cm) are not optimal, in the sense that the Top CRT has also vertical modules. I suggest making this "interceptable volume" a parallelepiped with the following boundaries:
YMin = 400 cm
YMax = 620 cm
XMin = -570 cm
XMax = 570 cm
ZMin = -1150 cm
ZMax = 1550 cm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed this by adding in a plane for each volume (based off of a slack conversation).

Copy link
Contributor

@tbwester tbwester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a useful module & seems like a reasonable first pass at implementation. Possibly in the future we could consider refactoring the existing CORSIKA module to avoid duplication between these.

@gputnam gputnam removed the request for review from jzennamo September 30, 2025 12:56
@kjplows kjplows moved this from Open pull requests to Testing in SBN software development Sep 30, 2025
@kjplows
Copy link
Contributor

kjplows commented Sep 30, 2025

trigger build ci_ref=v10_06_02 LArSoft/larsoft@LARSOFT_SUITE_v10_06_00_02 LArSoft/larwirecell@LARSOFT_SUITE_v10_06_00_02 LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbndcode@v10_06_00_05 SBNSoftware/sbn*@release/SBN2025A

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Testing to To merge in SBN software development Sep 30, 2025
@kjplows kjplows merged commit ea2af85 into release/SBN2025A Oct 1, 2025
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Oct 1, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Oct 1, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants