-
Notifications
You must be signed in to change notification settings - Fork 54
CRT-TPC Matching with Data #694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRT-TPC Matching with Data #694
Conversation
…uples' into feature/hlay_amoor_crt_tpc_matching_data
cb053b3 to
e8849d2
Compare
|
Cherry-picked to clean up commit history |
afm1g15
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I built this alongside PR #696 to fix the gdml. Everything seemed to be as expected when I ran things though and had a look around, so looks good to me @henrylay97!
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_06 SBNSoftware/sbncode@v10_04_06_01 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
Approved, changes are expected |
Description
This PR makes the relevant updates to include the two CRT-TPC matching algorithms into the data workflow. It includes work from both Alex Moor and myself.
Included is:
Note this PR does not fix known alignment problems between the CRT & TPC. In the interest of keeping PRs smaller I will prepare these GDML changes as a separate PR - the outputs of the matching algorithm are obviously dependent on this alignment fix. The algorithms still work well without this but are less performant.
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
Another sbndcode PR will follow with GDML changes but they can be treated independently from the point of view of release management despite resulting from the same work.
Link(s) to docdb describing changes (optional)