Skip to content

Conversation

@henrylay97
Copy link
Member

@henrylay97 henrylay97 commented Mar 21, 2025

Description

This PR makes the relevant updates to include the two CRT-TPC matching algorithms into the data workflow. It includes work from both Alex Moor and myself.

Included is:

  • Relevant fcl changes to add the modules to the workflow.
  • Changes to the CRTEventDisplay to visualise the matching.
  • Addition of fcl controllable (off by default) event display production within the matching producer modules.
  • Fixes for a bug in the track matching code that didn't account for the fact cathode crossing stitched tracks had already been shifted in x to fit the stitched t0.
  • Movement of some functions from the spacepoint matching alg to common utils so the event display can use them.
  • Addition of extra unrelated fcl that runs the decoders fcl disabling the output for the choppy filter path. I keep using this in various projects so it may as well be in the workflow.
  • Addition of new variables to CRTAnalysis trees to better analyse the matching performance.

Note this PR does not fix known alignment problems between the CRT & TPC. In the interest of keeping PRs smaller I will prepare these GDML changes as a separate PR - the outputs of the matching algorithm are obviously dependent on this alignment fix. The algorithms still work well without this but are less performant.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?

Relevant PR links (optional)

Another sbndcode PR will follow with GDML changes but they can be treated independently from the point of view of release management despite resulting from the same work.

Link(s) to docdb describing changes (optional)

@henrylay97 henrylay97 added crt Cosmic Ray Tagger tpc Time Projection Chamber reco1/reco2 Reconstruction data features for data processing labels Mar 21, 2025
@henrylay97 henrylay97 force-pushed the feature/hlay_amoor_crt_tpc_matching_data_pr branch from cb053b3 to e8849d2 Compare March 21, 2025 10:35
@henrylay97
Copy link
Member Author

Cherry-picked to clean up commit history

@henrylay97 henrylay97 mentioned this pull request Mar 21, 2025
6 tasks
Copy link

@afm1g15 afm1g15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built this alongside PR #696 to fix the gdml. Everything seemed to be as expected when I ran things though and had a look around, so looks good to me @henrylay97!

@bear-is-asleep
Copy link
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_04_06 SBNSoftware/sbncode@v10_04_06_01

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@bear-is-asleep bear-is-asleep moved this from Todo to To be Merged (RM only) in SBND March 2025 production Mar 27, 2025
@bear-is-asleep
Copy link
Contributor

Approved, changes are expected

@bear-is-asleep bear-is-asleep moved this from To be Merged (RM only) to Approved (RM only) in SBND March 2025 production Mar 27, 2025
@bear-is-asleep bear-is-asleep merged commit cf1945f into develop Apr 1, 2025
@bear-is-asleep bear-is-asleep moved this from Approved (RM only) to In tagged release in SBND March 2025 production Apr 1, 2025
@kjplows kjplows mentioned this pull request Apr 25, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crt Cosmic Ray Tagger data features for data processing reco1/reco2 Reconstruction tpc Time Projection Chamber

Projects

Status: In tagged release

Development

Successfully merging this pull request may close these issues.

5 participants