Feature/trigger work nikki pr #830
Conversation
miquelnebot
left a comment
miquelnebot
left a comment
There was a problem hiding this comment.
Looks good! Thank you for the amazing work
|
There is one bit of strange behavior I want to look into in data, with the large MonPulse multiplicity at the tail end of the waveforms. This might be being caused by the default values being used, but I don't understand it yet. |
|
Before adjusting the default values After adjusting the default values So we to set |
|
BeamRatesCalib_module fcl params are now sometimes redundant. That should not block this merge, as I am the only one who uses that module, but I should update it at some point in the future. |
|
running CI to catch anything not mentioned here that might be broken |
|
trigger build ci_ref=v10_10_02 LArSoft/lar*@LARSOFT_SUITE_v10_10_03 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbnd_data@v01_36_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
…ue changes, numPairsOverThreshold calculation, and saving MonPulse in the PMTDecoder
|
I am happy as soon as we verify the decoders can still run over raw data with the new changes |
|
Happy with all commits now |
|
trigger build ci_ref=v10_10_02 LArSoft/lar*@LARSOFT_SUITE_v10_10_03 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbnd_data@v01_36_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
linyan-w
moved this from Waiting on Reviewer
to In tagged release
in SBND 2025 Fall Production
Description
This includes updates to trigger code to include trigger emulation. Specifically this includes a new LArService that is called in both data and Monte Carlo analysis modules. The LArService include two functions originally from the data analyzer module (ConstructMonPulse and ConstructBinary response) and puts them in this general step that can be applied to both data and Monte Carlo. The functions have also been modified to work with data and Monte Carlo separately where needed. The data analyzer module now simply calls this LArService and the output matches the previous version. The Monte Carlo analyzer module calls this LArService too and now has an interface (in the analyzer module) that slices up the waveforms based on the triggers and consistent with the shorter 10us format of the data waveforms. These new triggered waveforms, the old triggered waveforms, a boolean of if the event passed/failed the trigger, and information to reconstruct the result of ConstructMonPulse (for the purposes of debugging during validation).
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
Link(s) to docdb describing changes (optional)
Is there a docdb describing the issue this solves or the feature added?
Here are a couple relevant links to presentations on this work: