Skip to content

Conversation

@npallat
Copy link
Contributor

@npallat npallat commented Oct 6, 2025

Description

Small update to CMakeLists: Nate reported that the GeoWrappers included in CMakeLists was giving build issues. I removed this (and a couple already commented out lines for housekeeping) and verified my MC and data analysis modules still build, run, and give expected results.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{red}\bf{\textrm{IMPORTANT UPDATE June 22nd 2025:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production (which started in Spring 2025), you must make two PRs: one for develop and one for the production/v10_06_00 branch.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
Nope!

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?
Relevant docdb: SBND Trigger Emulation.

@npallat npallat added the trigger label Oct 6, 2025
@npallat npallat self-assigned this Oct 6, 2025
@npallat npallat requested a review from nathanielerowe October 6, 2025 20:36
@npallat npallat linked an issue Oct 6, 2025 that may be closed by this pull request
@nathanielerowe nathanielerowe marked this pull request as ready for review October 6, 2025 21:25
@nathanielerowe
Copy link
Contributor

trigger build ci_ref=v10_10_03_01 LArSoft/lar*@LARSOFT_SUITE_v10_10_03 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbnd_data@v01_36_00 SBNSoftware/sbnanaobj@v10_00_10SBNSoftware/sbncode@v10_10_05 SBNSoftware/sbnobj@v10_10_02

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe nathanielerowe merged commit 3f714fe into develop Oct 6, 2025
3 of 4 checks passed
@linyan-w linyan-w moved this to In tagged release in SBND 2025 Fall Production Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: In tagged release

Development

Successfully merging this pull request may close these issues.

Trigger Emulation

4 participants