-
Notifications
You must be signed in to change notification settings - Fork 54
Update PMT calibration db for new PMT detsim #863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sbndcode/Calibration/configurations/calibration_database_PDS_TagSets_sbnd.fcl
Outdated
Show resolved
Hide resolved
|
@linyan-w is this good to go now? |
linyan-w
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now to me now! I think #873 needs to go in first otherwise this will be reverted by that.
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_12_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_12_02 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
approved |
Description
This PR modifies the PMT Calibration Database Service to provide the information requires for realistic PTM detsim. In particular, it adds function to retrieve:
It does also modify the database configuration file so it can access the latest database tag.
NOTE: This PR should be updated with commits from #873 once the latter is ready to be merged.
Please provide a detailed description of the changes this pull request introduces.
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
This PR requires merging SBNSoftware/sbnd_data#4
Link(s) to docdb describing changes (optional)
Is there a docdb describing the issue this solves or the feature added?