Feature/acastill tpcpmtbfm upgrade #144
Conversation
asanchezcastillo
requested review from
PetrilloAtWork,
fjnicolas and
linyan-w
linyan-w
moved this from Ready for CI
to Reviewer Approved
in SBND 2025 Fall Production
kjplows
moved this from Open pull requests
to Partially reviewed
in SBN software development
kjplows
moved this from Partially reviewed
to Urgent checks
in SBN software development
|
trigger build |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
github-project-automation
bot
moved this from To merge
to Done
in SBN software development
linyan-w
moved this from Reviewer Approved
to In tagged release
in SBND 2025 Fall Production
This PR adds new attributes to the TPCPMTBarycenterFM objects to store the chi2 and score that is used to perform matching after the upgrades to the algorithm. (SBNSoftware/sbndcode#807)