List all member by API

[iach526526]

Summary by CodeRabbit

• New Features

  • Added automated code formatting using the Black formatter to improve code consistency.
  • Introduced a new API endpoint /api/mlist for retrieving members from a Discord guild.

• Updates

  • Updated naming conventions in the GitHub Actions workflow for Pylint to enhance readability.

• Style

  • Improved readability of the codebase with consistent formatting adjustments across multiple files.

[coderabbitai]

Warning

Rate limit exceeded

@winstonsung has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 15 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between bf26ff8 and ac8bd26.

## Walkthrough

A new GitHub Actions workflow for automated code formatting using Black has been implemented, along with a minor update to the Pylint workflow name for consistency. The `pyproject.toml` file now specifies a version for Black, while multiple new dependencies have been introduced in `requirements_dev.txt`. Additionally, various Python files have been reformatted for improved readability, maintaining their existing functionality.

## Changes

| File                                      | Change Summary                                                               |
|-------------------------------------------|-----------------------------------------------------------------------------|
| `.github/workflows/black.yml`             | New workflow for automated code formatting using Black added.               |
| `.github/workflows/pylint.yml`            | Job name updated to "Analysing the code with Pylint."                      |
| `pyproject.toml`                          | Added dependency `"black == 24.8.0"` to `optional-dependencies.dev`.       |
| `requirements_dev.txt`                    | Added new dependencies: `black`, `click`, `mypy-extensions`, and `pathspec`. |
| Multiple Python files                      | Various files reformatted for consistency and readability.                  |

## Sequence Diagram(s)

```mermaid
sequenceDiagram
    participant Developer
    participant GitHubActions
    participant CodeFormatter

    Developer->>GitHubActions: Push code
    GitHubActions->>CodeFormatter: Trigger Black formatting
    CodeFormatter-->>GitHubActions: Format code
    GitHubActions->>Developer: Commit formatted code

Poem

In the realm of code where clarity reigns,
Black sweeps through, enhancing our gains.
With Pylint polished and devs in delight,
New dependencies shine, making coding bright.
Each refactor a dance, in harmony we play,
Together we code, come what may! 🎉🐱

<!-- walkthrough_end --><!-- This is an auto-generated comment: raw summary by coderabbit.ai -->

<!--

# Existing changesets

# Existing changesets

```markdown
.github/workflows/black.yml: ## AI-generated summary of changes

The newly introduced GitHub Actions workflow file, `black.yml`, automates the code formatting process for Python projects using the Black code formatter. This workflow is triggered by pull requests, pushes, and can also be manually initiated via the workflow dispatch feature. It consists of a single job named `build`, which runs on an Ubuntu environment and is configured to utilize Python version 3.11.

The workflow begins by checking out the repository's code with the `actions/checkout` action. It then sets up the specified Python version using `actions/setup-python`, ensuring the environment is ready for the subsequent steps. Following this, the workflow installs necessary dependencies by executing pip commands to upgrade pip and install packages listed in both `requirements.txt` and `requirements_dev.txt`.

Once the environment is prepared, the workflow formats the code by running the Black formatter on all Python files in the repository. This is accomplished through a command that identifies files with the `.py` extension, ensuring adherence to the style guidelines established by Black, which enhances consistency and readability across the codebase.

The workflow concludes with a step that automatically stages and commits any changes made by Black back to the repository. This step generates a commit message that references the last commit, indicating that formatting has been applied. Overall, this workflow significantly streamlines the development process by integrating automated code formatting, minimizing the need for manual formatting efforts, and maintaining code quality throughout the project's lifecycle.

## Alterations to the declarations of exported or public entities

- New workflow `Black` in `.github/workflows/black.yml`

---

.github/workflows/pylint.yml: ## AI-generated summary of changes

The diff introduces a minor yet significant update to the YAML configuration for a GitHub Actions workflow, specifically within the job dedicated to code analysis using Pylint. The primary modification involves the capitalization of "Pylint" in the job name, changing it from "Analysing the code with pylint" to "Analysing the code with Pylint." This change not only adheres to standard naming conventions for proper nouns but also enhances the overall readability and professionalism of the workflow file. While the adjustment is cosmetic and does not affect the underlying functionality or control flow of the workflow, it contributes to improved clarity for developers who review the workflow. The job continues to execute the same command for analyzing Python files, maintaining its original purpose without any alterations to its operational logic.

## Alterations to the declarations of exported or public entities

- `name: Analysing the code with pylint` in `.github/workflows/pylint.yml` → `name: Analysing the code with Pylint` in `.github/workflows/pylint.yml`

---

pyproject.toml: ## AI-generated summary of changes

The provided diff introduces a new dependency in the `optional-dependencies.dev` section of the `pyproject.toml` file. Specifically, the addition of `"black == 24.8.0"` integrates a specific version of the Black code formatter into the development environment. This change aims to standardize code formatting practices, enhancing consistency in code style, which ultimately improves readability and maintainability across the project. The overall structure of the `optional-dependencies.dev` section remains unchanged, with the new dependency added alongside existing tools such as `pylint` and `pytest`. Importantly, this modification does not alter any existing dependencies or their versions; instead, it expands the available tools for developers, reinforcing a commitment to high code quality standards.

## Alterations to the declarations of exported or public entities

- `"black == 24.8.0"` added to `optional-dependencies.dev` in `pyproject.toml`

---

requirements_dev.txt: ## AI-generated summary of changes

The provided diff shows modifications to the `requirements_dev.txt` file, which outlines the dependencies necessary for the project's development environment. The key change is the introduction of several new libraries, which enhances the tooling available to developers. Notably, `black` has been added for code formatting, promoting consistency in code style; `click` facilitates the creation of command-line interfaces, improving user interaction; `mypy-extensions` extends type hinting capabilities, contributing to better type safety; and `pathspec` provides functionality for matching file paths, which can streamline file operations. These additions reflect a strategic enhancement of the development environment aimed at improving code quality, maintainability, and developer productivity. The existing dependencies remain intact, suggesting that the core functionality of the project is unchanged while the development tools are upgraded to support better coding practices.

## Alterations to the declarations of exported or public entities

- `black == 24.8.0` added to `requirements_dev.txt`
- `click == 8.1.7` added to `requirements_dev.txt`
- `mypy-extensions == 1.0.0` added to `requirements_dev.txt`
- `pathspec == 0.12.1` added to `requirements_dev.txt`

---

app.py: ## AI-generated summary of changes

The provided diff introduces several enhancements and modifications to the `app.py` file, focusing primarily on code organization, error handling, and the addition of a new API endpoint. A significant change is the introduction of the `/api/mlist` endpoint through the new function `listt`, which allows authenticated users to retrieve a list of members from a specific Discord guild. This function begins by validating the user session; if no session exists, it returns a JSON response indicating that login is required, with a 403 status code. This ensures that only authenticated users can access the endpoint.

Upon successful session validation, the function retrieves the user's ID from the session and constructs an authorization header using the Discord bot token. It then makes an API call to fetch user data from a specific guild. If the request fails (indicated by a non-200 status code), the function responds with an error message and the corresponding status code. Additionally, the function checks if the user possesses a specific role (`send_gift_role`) within the fetched user data. If the user does not have this role, a JSON response indicating insufficient permissions is returned, also with a 403 status code. If the user has the required role, a second API call is made to retrieve a list of members from another specified guild, and the response data is returned in JSON format.

Moreover, the diff includes various formatting improvements throughout the code, such as consistent spacing around operators and parameters, which enhances readability. Several error handling responses have been standardized to provide clearer messages in case of failures, particularly in the `send` and `buy_product` functions. The overall structure of the code has been improved, with better organization of import statements and consistent use of quotation marks.

These changes collectively enhance the application's functionality by integrating with the Discord API, improving error handling, and ensuring a more readable and maintainable codebase.

## Alterations to the declarations of exported or public entities

- `def listt()` in `app.py` → New function `def listt()` in `app.py`
- `@app.route("/api/mlist")` in `app.py` → New route `@app.route("/api/mlist")` in `app.py`
- `@app.route("/buyProduct", methods=["POST"])` in `app.py` → `@app.route("/buyProduct", methods=["POST"])` in `app.py` (no change in functionality, just formatting)
- `def roll_slot() -> list:` in `app.py` → `def roll_slot() -> list:` in `app.py` (no change in functionality, just formatting)
- `@app.route("/rollSlot", methods=["POST"])` in `app.py` → `@app.route("/rollSlot", methods=["POST"])` in `app.py` (no change in functionality, just formatting)
- `def insert_user(user_id, table, cursor):` in `app.py` → `def insert_user(user_id, table, cursor):` in `app.py` (no change in functionality, just formatting)

---

build/build.py: ## AI-generated summary of changes

The diff introduces a minor modification to the `build/build.py` file by adding a blank line before the `Build` class definition. This change does not alter any functionality, logic, or control flow within the code. The addition of the blank line serves primarily as a formatting improvement, enhancing the readability of the code by providing visual separation between the import statements and the class declaration. There are no changes to the attributes, methods, or overall structure of the `Build` class or its interactions with other components within the module.

## Alterations to the declarations of exported or public entities

- No changes to the declarations of exported or public entities were made in `build/build.py`.

---

channel_check.py: ## AI-generated summary of changes

The provided diff for `channel_check.py` introduces several modifications primarily focused on formatting and code readability rather than altering the underlying functionality. The changes include adjustments to the indentation and spacing in function definitions and calls, which enhance the clarity of the code without changing its logic or control flow. 

In the `open_json` function, the file opening statement has been reformatted to improve readability by breaking it into multiple lines, although the functional aspect remains unchanged. The same formatting improvements are applied to the `update_channel` and `change_status` functions, where the parameters in function calls are adjusted to eliminate spaces around the equals sign, aligning with common Python style conventions. 

Additionally, there are minor adjustments in comments, specifically the spacing around the comments that indicate placeholders for guild and channel IDs. These changes do not affect the execution of the code but contribute to a cleaner and more consistent coding style.

Overall, the changes are cosmetic, focusing on formatting and style improvements, which enhance the maintainability of the code without impacting its functionality or performance.

## Alterations to the declarations of exported or public entities

- No alterations to the declarations of exported or public entities were made in `channel_check.py`.

---

cog/admin_gift.py: ## AI-generated summary of changes

The provided diff introduces several modifications to the `SendGift` class within the `cog/admin_gift.py` file, primarily focusing on formatting improvements and minor adjustments to the logic and control flow. The most notable changes include the enhancement of code readability through consistent formatting, such as the removal of spaces around the assignment operator and the alignment of comments. This improves the maintainability of the code without altering its core functionality.

The `Gift` class, a nested class within `SendGift`, retains its structure but benefits from improved formatting in method definitions and comments. The `__get_btn_attr` method's SQL query execution remains logically unchanged, but the formatting of the query string has been adjusted for better readability. The control flow in the `get_gift` method is preserved, but the error handling and user feedback mechanisms have been slightly reformatted for clarity.

The `send_dm_gift` method also sees similar formatting enhancements, particularly in the way parameters are defined and how responses are structured. The logic for checking user permissions and handling gift sending remains intact, ensuring that the functionality of sending gifts and managing user interactions is preserved. Overall, the changes focus on improving code clarity and maintainability while ensuring that the underlying logic and control flow remain consistent with previous implementations.

## Alterations to the declarations of exported or public entities

- `async def send_dm_gift(self, ctx, target_str: discord.Option(str, "發送對象（用半形逗號分隔多個使用者名稱）", required=True), gift_type: discord.Option(str, "送禮內容", choices=[ "電電點", "抽獎券" ] ), count: discord.Option(int, "數量")) -> None:` in class `SendGift` in `cog/admin_gift.py` → `async def send_dm_gift(self, ctx, target_str: discord.Option(str, "發送對象（用半形逗號分隔多個使用者名稱）", required=True), gift_type: discord.Option(str, "送禮內容", choices=["電電點", "抽獎券"]), count: discord.Option(int, "數量")) -> None:` in class `SendGift` in `cog/admin_gift.py`

---

cog/check_point.py: ## AI-generated summary of changes

The provided diff showcases several modifications within the `CheckPoint` class in the `cog/check_point.py` file. The primary changes involve formatting adjustments and minor enhancements to the logic flow, particularly in the `send_message` and `check` methods.

In the `send_message` method, the color code for the `discord.Embed` object has been standardized from `0x14e15c` to `0x14E15C`, ensuring consistent casing in the hexadecimal representation. This change, while superficial, may enhance readability and maintainability.

The method's logic remains intact, but the formatting of the code has been improved for clarity. The comments have been preserved, and the structure of the `add_field` calls has been modified to align with common Python style guidelines, specifically regarding spacing and indentation. This includes removing unnecessary spaces around the assignment operators and ensuring that the parameters in the `add_field` method are formatted consistently.

The `check` method also reflects similar formatting improvements, particularly in the comments and the spacing around the `link_sql()` function call. The logic of the method, which retrieves user data and invokes the `send_message` method, remains unchanged. The overall flow and functionality of the `CheckPoint` class are preserved, with the changes primarily focused on enhancing code readability and adherence to style conventions.

Lastly, the `setup` function, which registers the `CheckPoint` cog with the bot, remains unchanged, indicating that the integration of this cog into the broader bot framework is still intact.

## Alterations to the declarations of exported or public entities

- `async def check(self, interaction)` in class `CheckPoint` in `cog/check_point.py` → `async def check(self, interaction)` in class `CheckPoint` in `cog/check_point.py` (no signature change, but formatting improved)
- `async def send_message(self, point, combo, interaction)` in class `CheckPoint` in `cog/check_point.py` → `async def send_message(self, point, combo, interaction)` in class `CheckPoint` in `cog/check_point.py` (no signature change, but formatting improved)
- `def setup(bot)` in `cog/check_point.py` → `def setup(bot)` in `cog/check_point.py` (no signature change)

---

cog/class_role.py: ## AI-generated summary of changes

The provided diff reflects a series of modifications primarily focused on formatting improvements and minor adjustments in the `cog/class_role.py` file. The changes enhance code readability without altering the underlying functionality. 

Key alterations include the standardization of whitespace around parameters and arguments in function calls and class constructors. For instance, the `encoding` parameter in file operations has been consistently formatted, changing from `encoding = "utf-8"` to `encoding="utf-8"`. This pattern is repeated across various function calls, such as `json.dump()` and `discord.Embed()`, where spaces around the equals sign have been removed. 

Additionally, the diff includes minor adjustments to the structure of the `TokenVerifyButton` class and its associated methods. The `button_callback` method now consistently utilizes formatted strings without spaces around the equals sign in the parameters of the `discord.ui.InputText` constructor and the `discord.Embed` methods. 

The overall control flow remains unchanged, with the same logic for handling course data and user interactions retained. The error handling and data retrieval processes in the `get_courses`, `search_data`, and `add_data` functions are intact, ensuring that the functionality for managing course-related data continues to operate as expected. 

Furthermore, the `send_modal` and `add_class` commands have been reformatted for clarity, but their operational logic remains the same, preserving the command structure and permissions checks. The modifications do not introduce new features or alter existing ones, focusing solely on improving code clarity and consistency.

## Alterations to the declarations of exported or public entities

- `async def add_class(self, ctx, class_code: str, name: str, theme: str, teacher: str, time: str)` in class `ClassRole` in `cog/class_role.py` → `async def add_class(self, ctx, class_code: str, name: str, theme: str, teacher: str, time: str)` in class `ClassRole` in `cog/class_role.py` (no change in signature, but formatting improved)
- `async def send_modal(self, ctx)` in class `ClassRole` in `cog/class_role.py` → `async def send_modal(self, ctx)` in class `ClassRole` in `cog/class_role.py` (no change in signature, but formatting improved)

---

cog/comment.py: ## AI-generated summary of changes

The provided diff for `cog/comment.py` primarily involves formatting improvements, particularly concerning the alignment and spacing of code elements. These changes enhance readability without altering the underlying functionality or logic of the code. The modifications include consistent spacing around function parameters and arguments, as well as adjustments to comments to ensure they are properly aligned with the corresponding code. 

The control flow and logic of the functions remain intact, with no changes to the functionality of the methods such as `insert_user`, `get_channels`, `reset`, `reward`, and others. The exception handling mechanisms and database interactions are preserved, ensuring that the behavior of the bot remains unchanged. 

Overall, the changes are cosmetic, focusing on code style improvements rather than functional alterations. This includes the consistent use of spaces around operators and within function calls, which contributes to a cleaner codebase. The comments have also been adjusted for clarity, maintaining their original intent while improving their presentation.

## Alterations to the declarations of exported or public entities

- `def get_channels():` in `cog/comment.py` → `def get_channels():` in `cog/comment.py`
- `def insert_user(user_id, table, cursor):` in `cog/comment.py` → `def insert_user(user_id, table, cursor):` in `cog/comment.py`
- `def reset(message, now, cursor):` in `cog/comment.py` → `def reset(message, now, cursor):` in `cog/comment.py`
- `def reward(message, cursor):` in `cog/comment.py` → `def reward(message, cursor):` in `cog/comment.py`
- `class Comment(commands.Cog):` in `cog/comment.py` → `class Comment(commands.Cog):` in `cog/comment.py`
- `def setup(bot):` in `cog/comment.py` → `def setup(bot):` in `cog/comment.py`

---

cog/core/secret.py: ## AI-generated summary of changes

The provided diff reflects a series of formatting changes in the `cog/core/secret.py` file, primarily focusing on the consistency of string quotation marks and whitespace in the code. The changes enhance the readability and maintainability of the code without altering its functionality. Specifically, the diff modifies the way environment variables are defined and accessed by standardizing the use of double quotes (`"`) instead of single quotes (`'`). This change is applied uniformly across the variable declarations for `DB_USER`, `DB_PASSWORD`, `DB_NAME`, `DB_HOST`, and `DB_PORT`. 

Additionally, the `connect` function's implementation has been updated to align with this new quotation style. The parameters passed to the `mysql.connector.connect` function have also been reformatted to remove spaces around the equal signs, promoting a cleaner and more consistent coding style. Overall, these changes do not affect the underlying logic or control flow of the application but rather focus on stylistic consistency, which can facilitate easier collaboration and code reviews in the future.

## Alterations to the declarations of exported or public entities

- No alterations to the declarations of exported or public entities were made in `cog/core/secret.py`.

---

cog/core/sendgift.py: ## AI-generated summary of changes

The provided diff introduces several modifications to the `sendgift.py` file, primarily focusing on formatting improvements and maintaining functionality. The changes enhance the readability of the code without altering its core logic or control flow.

Key changes include the addition of line breaks and indentation adjustments in the definitions of the `send_gift_button` and `record_db` functions. These modifications improve the clarity of the function signatures by separating parameters onto new lines, which is particularly beneficial for functions with multiple parameters. This change does not affect the functionality but enhances maintainability and readability.

Additionally, the error handling in the `record_db` function remains intact, with the same logic for database insertion and exception raising. The `MessageSendError` and `DBError` exception classes are defined without changes to their functionality, but their formatting has been standardized for better readability.

Overall, the diff reflects a focus on code style improvements, particularly in terms of spacing and line breaks, while preserving the existing functionality and error handling mechanisms.

## Alterations to the declarations of exported or public entities

- `async def send_gift_button(self, target_user: discord.User, gift_type: str, count: int, sender: int) -> None:` in `cog/core/sendgift.py` → `async def send_gift_button(self, target_user: discord.User, gift_type: str, count: int, sender: int) -> None:` in `cog/core/sendgift.py` (formatting change)
- `async def record_db(btn_id: int, gift_type: str, count: int, recipient: str) -> None:` in `cog/core/sendgift.py` → `async def record_db(btn_id: int, gift_type: str, count: int, recipient: str) -> None:` in `cog/core/sendgift.py` (formatting change)
- `class MessageSendError(Exception):` in `cog/core/sendgift.py` → `class MessageSendError(Exception):` in `cog/core/sendgift.py` (formatting change)
- `class DBError(Exception):` in `cog/core/sendgift.py` → `class DBError(Exception):` in `cog/core/sendgift.py` (formatting change)

---

cog/core/sql.py: ## AI-generated summary of changes

The provided diff reflects a series of modifications primarily focused on code formatting and consistency within the `cog/core/sql.py` file. The changes include adjustments to whitespace, particularly the addition of blank lines for improved readability and the alignment of comments. These alterations do not affect the underlying logic or functionality of the code but enhance its clarity.

The function `end` remains unchanged in its logic, continuing to handle the closing of database connections and cursors appropriately. The `link_sql` function, which establishes a connection to the database, also retains its original functionality. 

The `write` function's logic is preserved, ensuring that if no records are found for a given user ID, a new entry is created before updating the specified property. Similarly, the `read` function continues to execute a SELECT statement to retrieve user properties, with the same fallback mechanism for inserting a user if none exists. 

The `user_id_exists` function maintains its role in checking the existence of a user ID in the database, with no changes to its operational flow. Overall, the modifications are cosmetic, aimed at enhancing code maintainability without altering the functional behavior of the database interaction methods.

## Alterations to the declarations of exported or public entities

- `def end(connection, cursor):` in `cog/core/sql.py` → `def end(connection, cursor):` in `cog/core/sql.py` (no functional change, only formatting)
- `def link_sql():` in `cog/core/sql.py` → `def link_sql():` in `cog/core/sql.py` (no functional change, only formatting)
- `def write(user_id, user_prop: str, value, cursor, table: str = "user") -> None:` in `cog/core/sql.py` → `def write(user_id, user_prop: str, value, cursor, table: str = "user") -> None:` in `cog/core/sql.py` (no functional change, only formatting)
- `def read(user_id, user_prop, cursor, table = "user"):` in `cog/core/sql.py` → `def read(user_id, user_prop, cursor, table="user"):` in `cog/core/sql.py` (no functional change, only formatting)
- `def user_id_exists(user_id, table, cursor):` in `cog/core/sql.py` → `def user_id_exists(user_id, table, cursor):` in `cog/core/sql.py` (no functional change, only formatting)

---

cog/ctf.py: ## AI-generated summary of changes

The provided diff introduces several modifications to the `cog/ctf.py` file, primarily focusing on formatting improvements and minor adjustments to the logic of existing functions. The changes enhance code readability and maintainability without altering the core functionality.

1. **Formatting Changes**: The most significant changes are related to code formatting, particularly in how parameters are presented in function calls and the organization of comments. For example, the formatting of the `with open(...)` statements has been updated to improve readability by breaking long lines into multiple lines. This change is consistent throughout the file, affecting multiple instances where file operations are performed.

2. **Function Logic**: The logic within several functions remains largely unchanged, but some minor adjustments have been made for clarity. For instance, the exception handling in the `callback` method of the `SubmitModal` class has been slightly reformatted to enhance readability. The overall flow of error handling and database interactions remains intact, ensuring that the functionality of the bot is preserved.

3. **Database Interaction**: The SQL queries within the various methods have been reformatted for consistency. The use of parentheses in multi-line SQL queries has been standardized, which aids in understanding the structure of the queries at a glance. This includes changes in the `create` and `delete_ctf` functions, where SQL commands are now more visually coherent.

4. **Command Decorators**: The command decorators for Discord commands have been updated to remove unnecessary spaces around parameters, contributing to a cleaner appearance. This change applies to commands such as `create`, `delete`, and `list`, ensuring uniformity across the command definitions.

5. **Error Messages**: Minor adjustments have been made to the wording of error messages returned to users, enhancing clarity and user experience. For example, the messages now have consistent formatting and improved phrasing for better communication with users.

Overall, the changes focus on improving code readability and maintainability without introducing any new features or altering existing functionality. The adjustments ensure that the code adheres to better formatting practices, which is crucial for collaborative development environments.

## Alterations to the declarations of exported or public entities

- `def get_ctf_makers() -> dict` in `cog/ctf.py` → `def get_ctf_makers() -> dict` in `cog/ctf.py` (no change in signature, but formatting improved)
- `def generate_ctf_id() -> str` in `cog/ctf.py` → `def generate_ctf_id() -> str` in `cog/ctf.py` (no change in signature, but formatting improved)
- `class CTF(Build)` in `cog/ctf.py` → `class CTF(Build)` in `cog/ctf.py` (no change in signature, but formatting improved)
- `async def on_ready(self) -> None` in `cog/ctf.py` → `async def on_ready(self) -> None` in `cog/ctf.py` (no change in signature, but formatting improved)
- `async def create(self, ctx, title: Option(str, "題目標題", required=True), flag: Option(str, "輸入 flag 解答", required=True), score: Option(int, "分數", required=True, default="20"), limit: Option(int, "限制回答次數", required=False, default="∞"), case: Option(bool, "大小寫忽略", required=False, default=False), start: Option(str, f"開始作答日期 ({datetime.now().strftime('%y-%m-%d %H:%M:%S')})", required=False, default=""), end: Option(str, f"截止作答日期 ({datetime.now().strftime('%y-%m-%d %H:%M:%S})", required=False, default="")) -> None` in `cog/ctf.py` → `async def create(self, ctx, title: Option(str, "題目標題", required=True), flag: Option(str, "輸入 flag 解答", required=True), score: Option(int, "分數", required=True, default="20"), limit: Option(int, "限制回答次數", required=False, default="∞"), case: Option(bool, "大小寫忽略", required=False, default=False), start: Option(str, f"開始作答日期 ({datetime.now().strftime('%y-%m-%d %H:%M:%S')})", required=False, default=""), end: Option(str, f"截止作答日期 ({datetime.now().strftime('%y-%m-%d %H:%M:%S})", required=False, default="")) -> None` in `cog/ctf.py` (no change in signature, but formatting improved)
- `async def delete_ctf(self, ctx, qid: discord.Option(str, "欲刪除的題目", required=True), channel_id: discord.Option(str, "題目所在的貼文頻道", required=True), key: discord.Option(str, "輸入該題題目解答", required=True)) -> None` in `cog/ctf.py` → `async def delete_ctf(self, ctx, qid: discord.Option(str, "欲刪除的題目", required=True), channel_id: discord.Option(str, "題目所在的貼文頻道", required=True), key: discord.Option(str, "輸入該題題目解答", required=True)) -> None` in `cog/ctf.py` (no change in signature, but formatting improved)
- `async def list_all(self, ctx) -> None` in `cog/ctf.py` → `async def list_all(self, ctx) -> None` in `cog/ctf.py` (no change in signature, but formatting improved)

---

cog/daily_charge.py: ## AI-generated summary of changes

The diff reflects several modifications to the `daily_charge.py` file, primarily focused on improving code readability and maintaining consistent formatting. The most notable changes involve the restructuring of multi-line statements and the adjustment of comments for clarity. 

The function `get_channels()` remains unchanged in its logic but has been reformatted for better readability, with the opening parenthesis moved to a new line. This pattern is consistent throughout the file, where multi-line statements are reformatted to enhance visual clarity. For instance, the `with open(...)` statements and the `discord.Embed(...)` calls are reformatted to align parameters vertically, making it easier to read and understand the structure of the code at a glance.

The `Charge` class and its methods, including `send_message`, `already_charge`, and `channel_error`, also see similar formatting improvements. The changes do not alter the underlying functionality but standardize the way parameters are presented and comments are formatted, ensuring that the code adheres to a more uniform style.

The `charge` method, which handles the core logic of the daily charge functionality, retains its original logic flow. However, the formatting of comments and inline documentation has been refined for clarity. The conditional checks and database interactions remain intact, ensuring that the method's operational integrity is preserved. The logic for checking if a user has already charged for the day and updating their charge combo and points is unchanged, maintaining the intended functionality.

Overall, the changes primarily focus on enhancing code readability and consistency without altering the functional behavior of the existing methods or logic.

## Alterations to the declarations of exported or public entities

- `def get_channels()` in `cog/daily_charge.py` → `def get_channels()` in `cog/daily_charge.py`
- `async def charge(self, interaction)` in `cog/daily_charge.py` → `async def charge(self, interaction)` in `cog/daily_charge.py`
- `def setup(bot)` in `cog/daily_charge.py` → `def setup(bot)` in `cog/daily_charge.py`

---

cog/game.py: ## AI-generated summary of changes

The provided diff reflects several modifications to the `cog/game.py` file, primarily focused on formatting improvements and minor adjustments to the control flow within the `Game` class. The changes enhance readability without altering the underlying functionality.

1. **Formatting Adjustments**: The most notable changes are related to the formatting of function parameters and dictionary accesses. The code now employs consistent spacing and line breaks, making it easier to read. For instance, the parameters of the `rock_paper_scissors` method and the `number_status` method have been reformatted to eliminate unnecessary spaces around the equals sign and to align with Python's PEP 8 style guide.

2. **Error Handling**: The error handling within the `get_channels` function remains intact, but the handling of the `FileNotFoundError` and JSON decoding errors has been preserved, ensuring that the function continues to provide feedback when configuration issues arise.

3. **Game Logic**: The core logic of the `rock_paper_scissors` method has not been altered; however, the formatting of the responses and the print statements has been standardized. This includes consistent use of string formatting, which enhances the clarity of the output messages sent to users.

4. **Consistency in Dictionary Access**: The access to dictionary keys has been made uniform. For example, the change from `["stickers"]['zap']` to `["stickers"]["zap"]` improves clarity and consistency in how data is accessed from the configuration.

5. **Command Decorators**: The decorators for the slash commands have been reformatted for consistency, removing unnecessary spaces around the parameters. This change does not affect functionality but aligns the code with best practices for readability.

Overall, the changes contribute to a cleaner and more maintainable codebase while preserving the original functionality of the commands and methods within the `Game` class.

## Alterations to the declarations of exported or public entities

- `async def rock_paper_scissors(self, interaction, choice: discord.Option(str, choices = [ "✊", "🤚", "✌️" ])` in class `Game` in `cog/game.py` → `async def rock_paper_scissors(self, interaction, choice: discord.Option(str, choices=["✊", "🤚", "✌️"])` in class `Game` in `cog/game.py`
- `async def number_status(self, interaction)` in class `Game` in `cog/game.py` → `async def number_status(self, interaction)` in class `Game` in `cog/game.py` (no changes in signature, but formatting adjusted)
- `var stickers = get_channels()["stickers"]['zap']` in `cog/game.py` → `var stickers = get_channels()["stickers"]["zap"]` in `cog/game.py` (no changes in signature, but formatting adjusted)

---

cog/rule_role.py: ## AI-generated summary of changes

The provided diff indicates minor modifications to the `RuleRoles` class within the `cog/rule_role.py` file. The primary change involves the formatting of the code, specifically the removal of spaces around the assignment of the `name` parameter in the `discord.utils.get` function calls. This adjustment enhances code readability and adheres to a more consistent style, but it does not alter the underlying functionality or logic of the code. 

The `on_raw_reaction_add` and `on_raw_reaction_remove` methods remain functionally unchanged; they still check for a specific message ID and emoji to either assign or remove a role from a member in a Discord server. The role being manipulated is consistently identified as "二月主題課程" in both methods. Furthermore, the `setup` function at the end of the file continues to add the `RuleRoles` cog to the bot without any modifications. Overall, the changes are purely stylistic, focusing on whitespace adjustments, and do not impact the control flow or the operational logic of the code.

## Alterations to the declarations of exported or public entities

- No changes to the signatures of exported or public entities were made in `cog/rule_role.py`.

---

cog/ticket.py: ## AI-generated summary of changes

The provided diff indicates several modifications to the `Ticket` class in `cog/ticket.py`, primarily focused on improving code readability and maintaining consistent formatting. The changes include adjustments to the syntax of function calls, particularly in the use of whitespace around parameters, which enhances the visual clarity of the code. For instance, the timeout parameter in the `super().__init__()` calls has been standardized to `timeout=None`, removing unnecessary spaces.

Additionally, the button definitions within the `DelView`, `CloseView`, and `TicketView` classes have been reformatted to align parameters vertically, which aids in readability. The color values in the `discord.Embed` calls have been changed to use uppercase hexadecimal notation (e.g., `0xFF0000` instead of `0xff0000`), promoting consistency across the codebase.

The logic within the button callbacks remains largely unchanged, but the formatting of the embed messages has been improved for better clarity. For example, the embed fields are now consistently formatted with proper spacing and alignment, making it easier to read and understand the structure of the messages being sent.

Overall, these changes do not alter the functionality of the `Ticket` class or its methods but rather enhance the readability and maintainability of the code. The control flow remains intact, with no modifications to the underlying logic or behavior of the ticketing system.

## Alterations to the declarations of exported or public entities

- `class Ticket(Build)` in `cog/ticket.py` → No change
- `async def create_ticket_button(self, ctx)` in `cog/ticket.py` → No change
- `async def create_ticket_channel(self, interaction, button_name)` in `cog/ticket.py` → No change
- `class DelView(discord.ui.View)` in `cog/ticket.py` → No change
- `class CloseView(discord.ui.View)` in `cog/ticket.py` → No change
- `class TicketView(discord.ui.View)` in `cog/ticket.py` → No change

No modifications were made to the signatures of exported or public entities in this diff. All changes were related to formatting and readability improvements without altering the function signatures or class declarations.

---

cog/voice_chat.py: ## AI-generated summary of changes

The provided diff introduces several modifications to the `VoiceChat` class in the `cog/voice_chat.py` file, primarily focusing on improving the readability and formatting of the code. The most significant change is the restructuring of the `on_voice_state_update` method, which handles the creation of a new voice channel when a member joins a specified voice channel. The logic remains intact, but the formatting of the `create_voice_channel` method call is enhanced for clarity. Specifically, the arguments for `create_voice_channel` are now presented on separate lines, which improves code readability, especially when dealing with longer parameter lists.

Additionally, a blank line was added after the import statements, which is a minor stylistic change that adheres to common Python coding standards, enhancing the overall organization of the code. The functionality related to checking and deleting empty channels remains commented out, indicating that while it is part of the original logic, it is not currently active. The control flow of the method is unchanged, as it still checks the member's voice state and creates a new channel accordingly. The asynchronous nature of the method is preserved, ensuring that the bot continues to operate efficiently without blocking.

Overall, the changes are primarily cosmetic, aimed at improving code readability and maintainability without altering the underlying functionality or logic of the `VoiceChat` class.

## Alterations to the declarations of exported or public entities

- `class VoiceChat(Build)` in `cog/voice_chat.py` → No change
- `async def on_voice_state_update(self, member, before, after)` in `cog/voice_chat.py` → No change
- `def setup(bot)` in `cog/voice_chat.py` → No change

---

main.py: ## AI-generated summary of changes

The provided diff reflects several modifications to the `main.py` file, primarily involving formatting adjustments and minor code style improvements. The most notable changes include the alignment of function parameters and the formatting of comments, which enhance readability without altering the underlying functionality. 

Specifically, the instantiation of the `discord.Bot` object has been reformatted to remove spaces around the equal sign in the `intents` parameter, aligning with common Python style guidelines. The context manager for opening the `token.json` file also underwent a similar change, with the spacing around the equal sign in the `encoding` argument being adjusted. These changes contribute to a cleaner and more consistent code style.

Additionally, the print statement within the loop that loads extensions has been reformatted to ensure consistent spacing after the comment. The overall control flow and logic of the bot remain unchanged, with the same events and tasks being scheduled as before. The modifications do not introduce new functionality or alter existing behavior; they merely refine the presentation of the code.

## Alterations to the declarations of exported or public entities

- No changes to the declarations of exported or public entities were made in `main.py`.

---

test/ctf_get.py: ## AI-generated summary of changes

The provided diff introduces minor modifications to the formatting and structure of the code in the `test/ctf_get.py` file. The most notable change is the addition of a line break and indentation in the SQL insertion command within a loop that processes historical data. This change enhances the readability of the code by allowing the SQL command to be split across multiple lines, making it clearer and easier to maintain. 

Additionally, there is a slight adjustment in the whitespace around the `encoding` parameter in the `open` function call, which standardizes the formatting but does not alter the functionality of the code. The overall logic of the script remains intact, as it continues to read a JSON file, process its contents, and insert data into a database using SQL commands. The control flow, which involves reading the JSON data, establishing a database connection, and executing SQL insertions based on the processed data, is preserved without any changes to the underlying logic.

## Alterations to the declarations of exported or public entities

- No alterations to the declarations of exported or public entities were made in `test/ctf_get.py`.

---

test/emoji.py: ## AI-generated summary of changes

The provided diff reflects a minor modification in the `analyze_string` function within the `test/emoji.py` file. The primary change is the alteration of the string concatenation method used to create the `transformed_string`. Originally, the string was concatenated using single quotes (`''`), and this has been updated to use double quotes (`""`). This change does not affect the functionality or the logic of the code, as both forms of string literals are functionally equivalent in Python. The output of the function remains unchanged, as the underlying logic for transforming elements and printing results is intact. Additionally, a blank line has been added after the print statements, which may enhance readability but does not alter the control flow or semantic behavior of the function.

## Alterations to the declarations of exported or public entities

- `def analyze_string(s)` in `test/emoji.py` → No change in signature.

New changesets

app.py: ## AI-generated summary of changes

The provided diff introduces several enhancements and modifications to the app.py file, focusing on code organization, error handling, and the addition of a new API endpoint. A significant change is the introduction of the /api/mlist endpoint through the new function listt, which allows authenticated users to retrieve a list of members from a specific Discord guild. This function begins by validating the user session; if no session exists, it returns a JSON response indicating that login is required, with a 403 status code. This ensures that only authenticated users can access the endpoint.

Upon successful session validation, the function retrieves the user's ID from the session and constructs an authorization header using the Discord bot token. It then makes an API call to fetch user data from a specific guild. If the request fails (indicated by a non-200 status code), the function responds with an error message and the corresponding status code. Additionally, the function checks if the user possesses a specific role (send_gift_role) within the fetched user data. If the user does not have this role, a JSON response indicating insufficient permissions is returned, also with a 403 status code. If the user has the required role, a second API call is made to retrieve a list of members from another specified guild, and the response data is returned in JSON format.

Moreover, the diff includes various formatting improvements throughout the code, such as consistent spacing around operators and parameters, which enhances readability. Several error handling responses have been standardized to provide clearer messages in case of failures, particularly in the send and buy_product functions. The overall structure of the code has been improved, with better organization of import statements and consistent use of quotation marks.

These changes collectively enhance the application's functionality by integrating with the Discord API, improving error handling, and ensuring a more readable and maintainable codebase.

Alterations to the declarations of exported or public entities

• def listt() in app.py → New function def listt() in app.py
• @app.route("/api/mlist") in app.py → New route @app.route("/api/mlist") in app.py
• @app.route("/buyProduct", methods=["POST"]) in app.py → @app.route("/buyProduct", methods=["POST"]) in app.py (no change in functionality, just formatting)
• def roll_slot() -> list: in app.py → def roll_slot() -> list: in app.py (no change in functionality, just formatting)
• @app.route("/rollSlot", methods=["POST"]) in app.py → @app.route("/rollSlot", methods=["POST"]) in app.py (no change in functionality, just formatting)
• def insert_user(user_id, table, cursor): in app.py → def insert_user(user_id, table, cursor): in app.py (no change in functionality, just formatting)

New changesets

.github/workflows/black.yml: ## AI-generated summary of changes

The newly introduced GitHub Actions workflow file, black.yml, automates the code formatting process for Python projects using the Black code formatter. This workflow is triggered by pull requests, pushes, and can also be manually initiated via the workflow dispatch feature. It consists of a single job named build, which runs on an Ubuntu environment and is configured to utilize Python version 3.11.

The workflow begins by checking out the repository's code with the actions/checkout action. It then sets up the specified Python version using actions/setup-python, ensuring the environment is ready for the subsequent steps. Following this, the workflow installs necessary dependencies by executing pip commands to upgrade pip and install packages listed in both requirements.txt and requirements_dev.txt.

Once the environment is prepared, the workflow formats the code by running the Black formatter on all Python files in the repository. This is accomplished through a command that identifies files with the .py extension, ensuring adherence to the style guidelines established by Black, which enhances consistency and readability across the codebase.

The workflow concludes with a step that automatically stages and commits any changes made by Black back to the repository. This step generates a commit message that references the last commit, indicating that formatting has been applied. Overall, this workflow significantly streamlines the development process by integrating automated code formatting, minimizing the need for manual formatting efforts, and maintaining code quality throughout the project's lifecycle.

Alterations to the declarations of exported or public entities

• New workflow Black in .github/workflows/black.yml

-->

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 6

Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 091bbee and 662056d.

Files selected for processing (6)

• .github/workflows/black.yml (1 hunks)
• .github/workflows/pylint.yml (1 hunks)
• app.py (1 hunks)
• pyproject.toml (1 hunks)
• requirements.txt (2 hunks)
• requirements_dev.txt (1 hunks)

Additional context used

actionlint

.github/workflows/black.yml

26-26: shellcheck reported issue in this script: SC2046:warning:1:7: Quote this to prevent word splitting

(shellcheck)

---

29-29: shellcheck reported issue in this script: SC2035:info:1:9: Use ./glob or -- glob so names with dashes won't become options

(shellcheck)

Ruff

app.py

59-59: Missing return type annotation for public function listt

(ANN201)

---

65-65: Trailing comma missing

Add trailing comma

(COM812)

---

76-76: Trailing comma missing

Add trailing comma

(COM812)

---

79-79: Trailing comma missing

Add trailing comma

(COM812)

Additional comments not posted (9)

requirements_dev.txt (4)

2-2: Purrfect addition of black for code formatting!

Adding black will help maintain consistent code style across the project.

---

3-3: click is a pawsome choice for CLI creation!

Including click can simplify command-line interface development.

---

9-9: mypy-extensions will make type hinting meow-nificent!

Adding mypy-extensions enhances type checking capabilities.

---

11-11: pathspec is a claw-some addition for file path matching!

This will be useful for specifying file patterns, especially with tools like black.

requirements.txt (3)

1-1: Upgrading aiohappyeyeballs is a purr-suasive choice!

The new version may include performance improvements or bug fixes.

---

2-2: aiohttp update is pawsitively beneficial!

Keeping aiohttp up-to-date ensures compatibility and access to the latest features.

---

22-22: werkzeug upgrade is meow-velous!

This minor version bump likely includes important fixes or enhancements.

.github/workflows/pylint.yml (1)

25-25: Capitalization change is purr-fectly consistent!

This improves readability and aligns with proper noun formatting.

pyproject.toml (1)

39-39: LGTM! Black dependency added successfully.

The addition of "black == 24.8.0" to the optional-dependencies.dev section is appropriate and aligns with the project's goals for consistent code formatting.

[winstonsung]

Rebase! Rebase! Rebase! Don't create merge commits!

@iach526526

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 662056d and c0a6465.

Files selected for processing (4)

• .github/workflows/black.yml (1 hunks)
• .github/workflows/pylint.yml (1 hunks)
• pyproject.toml (1 hunks)
• requirements_dev.txt (1 hunks)

Additional context used

actionlint

.github/workflows/black.yml

26-26: shellcheck reported issue in this script: SC2046:warning:1:7: Quote this to prevent word splitting

(shellcheck)

---

29-29: shellcheck reported issue in this script: SC2035:info:1:9: Use ./glob or -- glob so names with dashes won't become options

(shellcheck)

Additional comments not posted (5)

requirements_dev.txt (1)

2-3: Purrrfect additions for development!

The additions of black, click, mypy-extensions, and pathspec enhance the development environment by improving code quality and consistency. These tools are widely used and beneficial for maintaining a clean codebase.

Also applies to: 9-11

.github/workflows/pylint.yml (1)

25-25: Consistency is key!

The update to capitalize "Pylint" in the job name improves readability and aligns with naming conventions. This change is purrfectly fine!

.github/workflows/black.yml (2)

26-26: Quote the command substitution to prevent word splitting.

The shellcheck warning suggests quoting the command substitution to prevent unintended word splitting.

Apply this diff to fix the issue:

-        black $(git ls-files '*.py')
+        black "$(git ls-files '*.py')"

Tools

actionlint

26-26: shellcheck reported issue in this script: SC2046:warning:1:7: Quote this to prevent word splitting

(shellcheck)

---

29-29: Use ./* to avoid issues with filenames containing dashes.

The shellcheck warning suggests using ./* to prevent filenames with dashes from being interpreted as options.

Apply this diff to fix the issue:

-        git add *
+        git add ./*

Tools

actionlint

29-29: shellcheck reported issue in this script: SC2035:info:1:9: Use ./glob or -- glob so names with dashes won't become options

(shellcheck)

pyproject.toml (1)

39-39: Purr-fect addition of Black!

Adding Black as a development dependency helps maintain consistent code formatting. Make sure everyone on the team is aware of this change to avoid any formatting surprises. 🐾

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between c0a6465 and 4c21c99.

Files selected for processing (4)

• .github/workflows/black.yml (1 hunks)
• .github/workflows/pylint.yml (1 hunks)
• pyproject.toml (1 hunks)
• requirements_dev.txt (1 hunks)

Additional context used

actionlint

.github/workflows/black.yml

26-26: shellcheck reported issue in this script: SC2046:warning:1:7: Quote this to prevent word splitting

(shellcheck)

---

29-29: shellcheck reported issue in this script: SC2035:info:3:9: Use ./glob or -- glob so names with dashes won't become options

(shellcheck)

Additional comments not posted (4)

requirements_dev.txt (1)

2-11: Purrfect additions for development!

The new dependencies black, click, mypy-extensions, and pathspec are great choices to enhance code quality and maintainability. 🐾

.github/workflows/pylint.yml (1)

25-25: Paws up for consistency!

The capitalization of "Pylint" in the job name enhances readability and consistency. 🐾

.github/workflows/black.yml (1)

1-33: A meow-velous new workflow!

The new GitHub Actions workflow for Black is well-structured. 🐾

Note: Existing comments address shellcheck issues regarding quoting and globbing. Ensure these are resolved to prevent potential issues.

Tools

actionlint

26-26: shellcheck reported issue in this script: SC2046:warning:1:7: Quote this to prevent word splitting

(shellcheck)

---

29-29: shellcheck reported issue in this script: SC2035:info:3:9: Use ./glob or -- glob so names with dashes won't become options

(shellcheck)

pyproject.toml (1)

39-39: Purrfect addition of Black!

Adding Black to the development dependencies will help keep the code looking neat and tidy. 🐾

[coderabbitai]

Actionable comments posted: 20

Outside diff range comments (6)

app.py (6)

Line range hint 48-67: Add return type annotation.

Consider adding a return type annotation to the login function for better clarity.

def login() -> Response:

---

Line range hint 103-226: Refactor to reduce complexity.

The send function is too complex. Consider breaking it down into smaller functions for better readability and maintainability.

Tools

Ruff

183-183: Trailing comma missing

Add trailing comma

(COM812)

---

198-198: Trailing comma missing

Add trailing comma

(COM812)

---

205-205: Possible SQL injection vector through string-based query construction

(S608)

---

208-208: Do not catch blind exception: Exception

(BLE001)

---

214-214: Trailing comma missing

Add trailing comma

(COM812)

---

216-216: Comment contains ambiguous ： (FULLWIDTH COLON). Did you mean : (COLON)?

(RUF003)

---

220-220: Trailing comma missing

Add trailing comma

(COM812)

---

223-223: Do not catch blind exception: Exception

(BLE001)

---

225-225: Trailing comma missing

Add trailing comma

(COM812)

---

230-230: Missing return type annotation for public function callback

(ANN201)

---

Line range hint 228-287: Add return type annotation.

Consider adding a return type annotation to the callback function for better clarity.

def callback() -> Response:

Tools

Ruff

243-243: Probable use of requests call without timeout

(S113)

---

244-244: Trailing comma missing

Add trailing comma

(COM812)

---

252-252: Probable use of requests call without timeout

(S113)

---

270-270: Trailing comma missing

Add trailing comma

(COM812)

---

273-273: Comment contains ambiguous ， (FULLWIDTH COMMA). Did you mean , (COMMA)?

(RUF003)

---

285-285: Comment contains ambiguous ， (FULLWIDTH COMMA). Did you mean , (COMMA)?

(RUF003)

---

290-290: Missing return type annotation for public function discord_callback

(ANN201)

---

Line range hint 288-318: Add return type annotation.

Consider adding a return type annotation to the discord_callback function for better clarity.

def discord_callback() -> Response:

Tools

Ruff

302-302: Probable use of requests call without timeout

(S113)

---

303-303: Trailing comma missing

Add trailing comma

(COM812)

---

309-309: Probable use of requests call without timeout

(S113)

---

321-321: Missing return type annotation for public function staticfiles

(ANN201)

---

321-321: Missing type annotation for function argument path

(ANN001)

---

326-326: Missing return type annotation for public function profile

(ANN201)

---

356-356: Missing return type annotation for public function slot

(ANN201)

---

384-384: Missing return type annotation for public function product_list

(ANN201)

---

386-386: Unnecessary open mode parameters

Remove open mode parameters

(UP015)

---

388-388: Unnecessary assignment to products before return statement

Remove unnecessary assignment

(RET504)

---

392-392: Missing return type annotation for public function buy_product

Add return type annotation: str

(ANN201)

---

400-400: Unnecessary open mode parameters

Remove open mode parameters

(UP015)

---

Line range hint 391-430: Add return type annotation.

Consider adding a return type annotation to the buy_product function for better clarity.

def buy_product() -> str:

Tools

Ruff

302-302: Probable use of requests call without timeout

(S113)

---

303-303: Trailing comma missing

Add trailing comma

(COM812)

---

309-309: Probable use of requests call without timeout

(S113)

---

321-321: Missing return type annotation for public function staticfiles

(ANN201)

---

321-321: Missing type annotation for function argument path

(ANN001)

---

326-326: Missing return type annotation for public function profile

(ANN201)

---

356-356: Missing return type annotation for public function slot

(ANN201)

---

384-384: Missing return type annotation for public function product_list

(ANN201)

---

386-386: Unnecessary open mode parameters

Remove open mode parameters

(UP015)

---

388-388: Unnecessary assignment to products before return statement

Remove unnecessary assignment

(RET504)

---

392-392: Missing return type annotation for public function buy_product

Add return type annotation: str

(ANN201)

---

400-400: Unnecessary open mode parameters

Remove open mode parameters

(UP015)

---

Line range hint 431-478: Add return type annotation.

Consider adding a return type annotation to the roll_slot function for better clarity.

def roll_slot() -> list:

Tools

Ruff

457-457: String contains ambiguous ， (FULLWIDTH COMMA). Did you mean , (COMMA)?

(RUF001)

---

460-460: Unnecessary open mode parameters

Remove open mode parameters

(UP015)

---

463-465: Standard pseudo-random generators are not suitable for cryptographic purposes

(S311)

---

464-464: Trailing comma missing

Add trailing comma

(COM812)

Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between d3ecab4 and 91d1ee7.

Files selected for processing (1)

• app.py (17 hunks)

Additional context used

Ruff

app.py

46-46: Missing return type annotation for public function not_found_error

(ANN201)

---

46-46: Missing type annotation for function argument error

(ANN001)

---

46-46: Unused function argument: error

(ARG001)

---

69-69: Missing return type annotation for public function logout

(ANN201)

---

75-75: Missing return type annotation for public function listt

(ANN201)

---

79-79: Trailing comma missing

Add trailing comma

(COM812)

---

95-95: Trailing comma missing

Add trailing comma

(COM812)

---

105-105: send is too complex (13 > 10)

(C901)

---

105-105: Missing return type annotation for public function send

(ANN201)

---

105-105: Missing type annotation for function argument target_user_id

(ANN001)

---

110-110: Trailing comma missing

Add trailing comma

(COM812)

---

125-125: Trailing comma missing

Add trailing comma

(COM812)

---

155-155: Trailing comma missing

Add trailing comma

(COM812)

---

157-157: Do not catch blind exception: Exception

(BLE001)

---

159-159: Trailing comma missing

Add trailing comma

(COM812)

---

172-172: Comment contains ambiguous （ (FULLWIDTH LEFT PARENTHESIS). Did you mean ( (LEFT PARENTHESIS)?

(RUF003)

---

172-172: Comment contains ambiguous ） (FULLWIDTH RIGHT PARENTHESIS). Did you mean ) (RIGHT PARENTHESIS)?

(RUF003)

---

183-183: Trailing comma missing

Add trailing comma

(COM812)

---

198-198: Trailing comma missing

Add trailing comma

(COM812)

---

205-205: Possible SQL injection vector through string-based query construction

(S608)

---

208-208: Do not catch blind exception: Exception

(BLE001)

---

214-214: Trailing comma missing

Add trailing comma

(COM812)

---

216-216: Comment contains ambiguous ： (FULLWIDTH COLON). Did you mean : (COLON)?

(RUF003)

---

220-220: Trailing comma missing

Add trailing comma

(COM812)

---

223-223: Do not catch blind exception: Exception

(BLE001)

---

225-225: Trailing comma missing

Add trailing comma

(COM812)

---

243-243: Probable use of requests call without timeout

(S113)

---

244-244: Trailing comma missing

Add trailing comma

(COM812)

---

252-252: Probable use of requests call without timeout

(S113)

---

270-270: Trailing comma missing

Add trailing comma

(COM812)

---

273-273: Comment contains ambiguous ， (FULLWIDTH COMMA). Did you mean , (COMMA)?

(RUF003)

---

285-285: Comment contains ambiguous ， (FULLWIDTH COMMA). Did you mean , (COMMA)?

(RUF003)

---

302-302: Probable use of requests call without timeout

(S113)

---

303-303: Trailing comma missing

Add trailing comma

(COM812)

---

309-309: Probable use of requests call without timeout

(S113)

---

321-321: Missing return type annotation for public function staticfiles

(ANN201)

---

321-321: Missing type annotation for function argument path

(ANN001)

---

326-326: Missing return type annotation for public function profile

(ANN201)

---

356-356: Missing return type annotation for public function slot

(ANN201)

---

384-384: Missing return type annotation for public function product_list

(ANN201)

---

386-386: Unnecessary open mode parameters

Remove open mode parameters

(UP015)

---

388-388: Unnecessary assignment to products before return statement

Remove unnecessary assignment

(RET504)

---

392-392: Missing return type annotation for public function buy_product

Add return type annotation: str

(ANN201)

---

400-400: Unnecessary open mode parameters

Remove open mode parameters

(UP015)

---

428-428: String contains ambiguous ！ (FULLWIDTH EXCLAMATION MARK). Did you mean ! (EXCLAMATION MARK)?

(RUF001)

---

444-444: Unnecessary open mode parameters

Remove open mode parameters

(UP015)

---

457-457: String contains ambiguous ， (FULLWIDTH COMMA). Did you mean , (COMMA)?

(RUF001)

---

460-460: Unnecessary open mode parameters

Remove open mode parameters

(UP015)

---

464-464: Trailing comma missing

Add trailing comma

(COM812)

---

475-475: String contains ambiguous ， (FULLWIDTH COMMA). Did you mean , (COMMA)?

(RUF001)

---

484-484: Missing return type annotation for public function github_login

(ANN201)

---

492-492: Missing return type annotation for public function github_callback

(ANN201)

---

495-495: Possible hardcoded password assigned to: "token_url"

(S105)

---

503-503: Probable use of requests call without timeout

(S113)

---

511-511: Missing return type annotation for public function star_uwu

(ANN201)

---

512-512: Missing return type annotation for private function insert_user

Add return type annotation: None

(ANN202)

---

512-512: Missing type annotation for function argument user_id

(ANN001)

---

512-512: Missing type annotation for function argument table

(ANN001)

---

512-512: Missing type annotation for function argument cursor

(ANN001)

---

512-512: Comment contains ambiguous （ (FULLWIDTH LEFT PARENTHESIS). Did you mean ( (LEFT PARENTHESIS)?

(RUF003)

---

512-512: Comment contains ambiguous ） (FULLWIDTH RIGHT PARENTHESIS). Did you mean ) (RIGHT PARENTHESIS)?

(RUF003)

---

523-523: Trailing comma missing

Add trailing comma

(COM812)

---

529-529: Probable use of requests call without timeout

(S113)

---

546-546: Probable use of requests call without timeout

(S113)

---

553-553: Trailing comma missing

Add trailing comma

(COM812)

---

554-554: Comment contains ambiguous ， (FULLWIDTH COMMA). Did you mean , (COMMA)?

(RUF003)

---

572-572: Use of debug=True in Flask app detected

(S201)

Additional comments not posted (1)

app.py (1)

110-112: Add trailing comma for better diffs.

Adding a trailing comma helps in maintaining cleaner diffs in future changes.

    api_admin = session.get(
        "user",
    )

Likely invalid or redundant comment.

Tools

Ruff

110-110: Trailing comma missing

Add trailing comma

(COM812)

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 91d1ee7 and bf26ff8.

Files selected for processing (1)

• .github/workflows/black.yml (1 hunks)

Additional context used

actionlint

.github/workflows/black.yml

27-27: shellcheck reported issue in this script: SC2046:warning:1:7: Quote this to prevent word splitting

(shellcheck)

---

30-30: shellcheck reported issue in this script: SC2035:info:3:9: Use ./glob or -- glob so names with dashes won't become options

(shellcheck)

Additional comments not posted (2)

.github/workflows/black.yml (2)

27-27: Quote the command substitution to prevent word splitting.

The shellcheck warning suggests quoting the command substitution to prevent unintended word splitting. This is a common issue when using command substitutions in shell scripts.

-        black $(git ls-files '*.py')
+        black "$(git ls-files '*.py')"

Tools

actionlint

27-27: shellcheck reported issue in this script: SC2046:warning:1:7: Quote this to prevent word splitting

(shellcheck)

---

30-30: Use ./* to avoid issues with filenames containing dashes.

The shellcheck warning suggests using ./* to prevent filenames with dashes from being interpreted as options. This is a best practice to ensure that filenames are handled correctly.

-        git add *
+        git add ./*

Tools

actionlint

30-30: shellcheck reported issue in this script: SC2035:info:3:9: Use ./glob or -- glob so names with dashes won't become options

(shellcheck)

[winstonsung]

git config pull.rebase true

@iach526526

[elvisdragonmao]

@winstonsung 你這樣算改好了嗎?

[elvisdragonmao]

先這樣吧，趕時間

[winstonsung]

好了，Black有正常運作了。

[winstonsung]

（CI過了就是有正常。）

[winstonsung]

commit打架現場。