Extra shutter functions / Revision of camera integration time writing / Revision of diagnostics plotting#34
Open
ThoMattheussen wants to merge 14 commits intoSCIFY-IvS:mainfrom
Open
Extra shutter functions / Revision of camera integration time writing / Revision of diagnostics plotting#34ThoMattheussen wants to merge 14 commits intoSCIFY-IvS:mainfrom
ThoMattheussen wants to merge 14 commits intoSCIFY-IvS:mainfrom
Conversation
…nt state (open/closed) of shutters, throwing an exception when neither. Addition of error handling in shutter_set. Only pushing a move command to RPC for the shutters whose input state differs from its current state. Addition of frame_sequence, allowing for retrieval of frames in arbitrary shutter state, bringing back the shutters to their initial state after.
…lass when start_recording is called. Writing this field value to redis with for each recorded frame. Remember to stop recording before and start recording again after changing the integration time.
…s. Bug fixes in diagnostics plotting. Change of shutter control, to only sleep when wait is True AND motion has been requested to >= 1 shutter
…times to redis in one thread, guaranteeing the latter is never done before the former. Warning the user whenever a frame file could not be found/loaded upon Frame initialization, based on ids.
…user desires camera data with certain shutters closed, can do so via frame_sequence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.