Global reference domain for offline analysis#2154
Merged
akenmorris merged 2 commits intomasterfrom Oct 24, 2023
Merged
Conversation
JakeWags
approved these changes
Oct 24, 2023
Contributor
JakeWags
left a comment
JakeWags
left a comment
There was a problem hiding this comment.
Looks good. Seems like it'd be simple enough to change the Alignment type based on a command argument if we decide to go that path.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the alignment reference domain in the offline analysis. Previously, the computed shapes would overlap:
Now we use the global alignment:
This PR also fixes the output location of the mean shape and particles (source vs target)