Context root is 404 without trailing slash

I've discovered that contexts are not properly matched when the URI is the context root and there is no trailing slash. E.g., given a context with the settings base_url set to /context/ and site_url set to https://www.domain.com/context/ the URI /context/ will load but /context is 404. I modified the following code to fix it:
`// find matching hosts
$matched_contexts = $contexts['_hosts'][$http_host];

        foreach ((array) $matched_contexts as $index => $ckey) {
            
            $context = $contexts[$ckey];
            $cbase = $contexts[$ckey]['base_url'];
            $requestUrl = rtrim($requestUrl, '/').'/';
            $strpos = strpos($requestUrl, $cbase);
            if ($strpos === 0) {
                $matches[strlen($contexts[$ckey]['base_url'])] = $ckey;
            }
        }

    // modify request for the matched context
        if (!empty($matches)) {
            
            $cSettings = $contexts[$matches[max(array_keys($matches))]];
            $cKey = $matches[max(array_keys($matches))];
            
            // do we need to switch the context?
            if ($modx->context->get('key') != $cKey) {
                $modx->switchContext($cKey);
            }
            
            // remove base_url from request query
            if ($cSettings['base_url'] != $modx_base_url) {
                $newRequestUrl = str_replace($cSettings['base_url'],'',$requestUrl);
                if(strpos($newRequestUrl, 'apply/') != -1) $newRequestUrl = rtrim($newRequestUrl, '/');
                $_REQUEST[$modx->getOption('request_param_alias', null, 'q')] = $newRequestUrl;
            }
            
            
        } else if ($_REQUEST['xrouting-debug'] != '1' || !$modx->getOption('xrouting.allow_debug_info', null, false)) {
            // if no match found
            if ($modx->getOption('xrouting.show_no_match_error', null, true)) {
                $modx->sendErrorPage();
            } else {
                $modx->switchContext($modx->getOption('xrouting.default_context', null, 'web'));
            }
            
        }`

This works but there's a weird quirk I don't understand. When a Rewrite Rule is matched in htaccess it creates an infinite loop with certain ones (not all of them). Trimming the trailing slash from one of the redirects (you can see where i'm doing this in the "remove base_url" block) somehow fixes the issue for every redirect even though the URLs are totally unrelated.

[JoshuaLuckers]

I fixed this issue another way.
Find and replace:

XRouting/core/components/xrouting/elements/plugins/xrouting.plugin.php

Lines 112 to 119 in 3397ed8

	foreach ((array) $matched_contexts as $index => $ckey) {
	$context = $contexts[$ckey];
	$strpos = strpos($requestUrl, $contexts[$ckey]['base_url']);
	if ($strpos === 0) {
	$matches[strlen($contexts[$ckey]['base_url'])] = $ckey;
	}
	}

            foreach ((array) $matched_contexts as $index => $ckey) {
                
                $context = $contexts[$ckey];
                if ($requestUrl === rtrim($contexts[$ckey]['base_url'], '/')) {
                    $requestUrl .= '/';
                }
                $strpos = strpos($requestUrl, $contexts[$ckey]['base_url']);
                
                if ($strpos === 0) {
                    $matches[strlen($contexts[$ckey]['base_url'])] = $ckey;
                }
            }

[christianseel]

Hi guys, from my understanding that change could raise issues like this:

Context 1 with base_url / and a Resource with aliassubpath
Context 2 with base_url /subpath/ and a Resource with alias /

A request with the URL https://example.com/subpath does need to match context 1, not 2.
With your suggested change it would match context 2, if I'm not misreading the code.

My assumption is, that when talking about a base_uri != / a trailing slash in the request URL is mandatory. That's also because the base_url does have a trailing slash as well.

So I'm in favor of calling that behavior "by design" and expected.
What do you think?

@christianseel so then what would be the correct way to make both /subpath/ and /subpath match the same context?

[JoshuaLuckers]

What if the the suggested change is optional? I would be happy with that.