removed const-ness from dump method on based Software_Probe and Softw…#2
Open
jonboan wants to merge 1 commit intoSEDS:masterfrom
Open
removed const-ness from dump method on based Software_Probe and Softw…#2jonboan wants to merge 1 commit intoSEDS:masterfrom
jonboan wants to merge 1 commit intoSEDS:masterfrom
Conversation
…are_Probe_Impl to have correct method signature with generated PDL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OASIS/OASIS_PDL/be/cpp/Impl_Dump_Generator.cpp
OASIS/OASIS_PDL/be/cpp/Stub_Dump_Generator.cpp
both generate output
virtual void dump(std::ostream &);
which are inconsistent with the base class definitions in Software_Probe.h and Software_Probe_Impl.h which are 'const' and although I agree with the const-ness qualify on the base classes modifying the generators leads to an explosion of problems.