You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The "show" property on xAxis is no longer being updated, so toggling axis visibility has no effect. You should always spread show: axisData.showAxis into the option regardless of title visibility. This will restore the original axis-show toggle behavior.
if (option.hasOwnProperty("xAxis") && option["xAxis"]) {
+ option["xAxis"] = {+ ...option["xAxis"],+ show: axisData.showAxis,+ };
if (axisData.showAxisTitle) {
// name and nameTextStyle updates...
} else {
option["xAxis"] = {
...option["xAxis"],
- ["name"]: "",+ name: "",
};
}
}
Suggestion importance[1-10]: 9
__
Why: The PR removed updating the show flag on the X axis in updateChartData, breaking axis toggling; restoring it fixes a critical functionality bug.
High
Add yAxis show property
Similar to the X axis, the "show" flag on yAxis is never set, so hiding/showing the Y axis does nothing. Always include show: axisData.showAxis when updating option.yAxis.
if (option.hasOwnProperty(axis) && option[axis]) {
+ option["yAxis"] = {+ ...option["yAxis"],+ show: axisData.showAxis,+ };
if (axisData.showAxisTitle) {
// name and nameTextStyle updates...
} else {
option["yAxis"] = {
...option["yAxis"],
- ["name"]: "",+ name: "",
};
}
}
Suggestion importance[1-10]: 9
__
Why: Similar to the X axis, the Y axis show flag was omitted in updateChartData, preventing axis visibility toggling and requiring restoration.
High
Fix popover close handler
The onMouseLeave handler currently returns the function instead of calling it, so the popover never closes. Change it to directly reference or invoke handlePopoverClose.
Why: The onMouseLeave callback returns the function instead of invoking or referencing it, so the popover never closes; correcting it improves UI behavior.
Bar chart x-axis and y-axis title show/hide toggle bug
Corrected axis title font size handling when hidden or shown
to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed Barchart x-Axis and y-Axis label show and hide bug