Skip to content

build(block): add additional icons to icon block in drag and drop#1138

Merged
johbaxter merged 1 commit intodevfrom
845-need-to-add-additional-icons-to-icon-block-in-drag-and-drop
May 14, 2025
Merged

build(block): add additional icons to icon block in drag and drop#1138
johbaxter merged 1 commit intodevfrom
845-need-to-add-additional-icons-to-icon-block-in-drag-and-drop

Conversation

@JaganSomannaKanini
Copy link
Copy Markdown
Contributor

Description

Add additional icons to icon block in drag and drop, that is a shopping cart icon and a Bell icon.

Changes Made

Added shopping cart and bell icon in constants.ts file.

How to Test

Drag and drop the icon block and in the block settings select the shopping cart and bell icons in the dropdown.

Notes

image
image

@JaganSomannaKanini JaganSomannaKanini requested a review from a team as a code owner May 14, 2025 11:29
@JaganSomannaKanini JaganSomannaKanini linked an issue May 14, 2025 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

@CodiumAI-Agent /describe

@github-actions
Copy link
Copy Markdown

@CodiumAI-Agent /review

@QodoAI-Agent
Copy link
Copy Markdown

Title

build(block): add additional icons to icon block in drag and drop


User description

Description

Add additional icons to icon block in drag and drop, that is a shopping cart icon and a Bell icon.

Changes Made

Added shopping cart and bell icon in constants.ts file.

How to Test

Drag and drop the icon block and in the block settings select the shopping cart and bell icons in the dropdown.

Notes

image
image


PR Type

Enhancement, Bug fix


Description

  • Add ShoppingCart and Bell icons

  • Remove DATABASE case in API call

  • Standardize quotes and formatting

  • Refactor popover/table indentation


Changes walkthrough 📝

Relevant files
Enhancement
constants.ts
Add shopping cart and bell icons                                                 

libs/renderer/src/constants.ts

  • Add Shopping Cart icon mapping
  • Add Bell icon mapping
+2/-0     
Formatting
MembersTable.tsx
Refactor MembersTable formatting                                                 

packages/client/src/components/settings/MembersTable.tsx

  • Remove DATABASE from getMembersApi
  • Standardize quote styles
  • Refactor indentation and formatting
  • +31/-21 
    UserPopover.tsx
    Format UserPopover JSX structure                                                 

    packages/client/src/components/settings/UserPopover.tsx

  • Break JSX props into multiple lines
  • Standardize quotation marks
  • Adjust Avatar JSX indentation
  • +16/-4   
    UserTable.tsx
    Refactor UserTable formatting                                                       

    packages/client/src/components/settings/UserTable.tsx

  • Standardize quotes in props
  • Refactor checkbox logic indentation
  • Align onMouseEnter arrow function
  • +24/-18 

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @github-actions
    Copy link
    Copy Markdown

    @CodiumAI-Agent /improve

    @QodoAI-Agent
    Copy link
    Copy Markdown

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Popover Close Bug

    The onMouseLeave handler references handlePopoverClose instead of invoking it, preventing the popover from closing on mouse leave.

    onMouseEnter={(
        event,
    ) => {
        setAnchorEl(
            event.currentTarget,
        );
        setHoveredUser(
            user,
        );
    }}
    onMouseLeave={() =>
        handlePopoverClose
    }
    Popover Close Bug

    The onMouseLeave handler references handlePopoverClose instead of invoking it, causing the popover to remain open on mouse leave.

    direction="row"
    onMouseEnter={(
        event,
    ) => {
        setAnchorEl(
            event.currentTarget,
        );
        setHoveredUser(
            user,
        );
    }}
    onMouseLeave={() =>
        handlePopoverClose

    @QodoAI-Agent
    Copy link
    Copy Markdown

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Invoke popover close handler

    The onMouseLeave handler currently returns the function reference instead of calling
    it. Update it to invoke handlePopoverClose so the popover actually closes on mouse
    leave.

    packages/client/src/components/settings/MembersTable.tsx [856-858]

    -onMouseLeave={() =>
    -    handlePopoverClose
    -}
    +onMouseLeave={handlePopoverClose}
    Suggestion importance[1-10]: 7

    __

    Why: The current onMouseLeave handler returns the function reference instead of calling it, so the popover won’t close. Changing to onMouseLeave={handlePopoverClose} correctly invokes it.

    Medium

    @johbaxter johbaxter merged commit 27f71f1 into dev May 14, 2025
    4 checks passed
    @johbaxter johbaxter deleted the 845-need-to-add-additional-icons-to-icon-block-in-drag-and-drop branch May 14, 2025 20:57
    @github-actions
    Copy link
    Copy Markdown

    @CodiumAI-Agent /update_changelog

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    Need to Add Additional Icons to Icon Block in Drag and Drop

    3 participants