Skip to content

build(brush): brush issues with bar chart#1144

Merged
johbaxter merged 1 commit intodevfrom
1117-brush-event-bugs
May 14, 2025
Merged

build(brush): brush issues with bar chart#1144
johbaxter merged 1 commit intodevfrom
1117-brush-event-bugs

Conversation

@johbaxter
Copy link
Copy Markdown
Contributor

Description

Changes Made

How to Test

  1. Steps to reproduce/test the behavior
  2. Expected outcomes

Notes

@johbaxter johbaxter requested a review from a team as a code owner May 14, 2025 17:54
@johbaxter johbaxter linked an issue May 14, 2025 that may be closed by this pull request
4 tasks
@github-actions
Copy link
Copy Markdown

@CodiumAI-Agent /describe

@QodoAI-Agent
Copy link
Copy Markdown

Title

build(brush): brush issues with bar chart


User description

Description

Changes Made

How to Test

  1. Steps to reproduce/test the behavior
  2. Expected outcomes

Notes


PR Type

Bug fix


Description

  • Standardize axis label casing in constants

  • Enable brush events on bar chart axes


Changes walkthrough 📝

Relevant files
Bug fix
Constant.tsx
Correct axis label casing                                                               

libs/renderer/src/components/block-defaults/echart-visualization-block/variant/Constant.tsx

  • Rename label from "xaxis" to "xAxis"
  • Rename label from "yaxis" to "yAxis"
  • +2/-2     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @github-actions
    Copy link
    Copy Markdown

    @CodiumAI-Agent /review

    @QodoAI-Agent
    Copy link
    Copy Markdown

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Backwards Compatibility

    Changing the label values from lowercase to camelCase may break existing consumers relying on the old strings. Verify all usage points accept xAxis/yAxis.

        label: "xAxis",
    },
    {
        name: "Y Axis",
        multiLabel: true,
        label: "yAxis",

    @github-actions
    Copy link
    Copy Markdown

    @CodiumAI-Agent /improve

    @QodoAI-Agent
    Copy link
    Copy Markdown

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Impact
    General
    Add deprecated label alias

    Add a deprecated alias for the old lowercase key so that any consumers relying on
    "xaxis" continue to work after this rename. This prevents a breaking change for
    existing code that hasn’t been updated.

    libs/renderer/src/components/block-defaults/echart-visualization-block/variant/Constant.tsx [5]

     label: "xAxis",
    +deprecatedLabel: "xaxis",
    Suggestion importance[1-10]: 7

    __

    Why: Adding a deprecated alias maintains backward compatibility and prevents breaking changes for users still relying on the old xaxis key.

    Medium

    @johbaxter johbaxter merged commit 170b06b into dev May 14, 2025
    4 checks passed
    @johbaxter johbaxter deleted the 1117-brush-event-bugs branch May 14, 2025 18:25
    @github-actions
    Copy link
    Copy Markdown

    @CodiumAI-Agent /update_changelog

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    Brush Event Bugs

    3 participants