You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The removal branch in updateAliasCountObj sets the old alias count to zero and deletes it instead of decrementing by one, which may prematurely remove alias entries.
The indeterminate calculation for the "Select All" checkbox uses dataImportwatch inline and may not reflect the latest form state or could incur performance overhead. Verify correctness and efficiency.
<Checkboxchecked={
isAllSelected
}// Checked if all rows are selectedindeterminate={
checkedColumnsCount >0&&checkedColumnsCount<dataImportwatch("tables",)[tableIndex].columns.length}onChange={()=>addAllTableColumnsHandler(tableIndex,
Replace the single boolean isAllSelected with a per-table selection map to avoid conflicts when multiple tables are present. This ensures each table's "select all" state is tracked independently.
-const [isAllSelected, setIsAllSelected] = useState<boolean>(false);+const [isAllSelectedMap, setIsAllSelectedMap] = useState<Record<number, boolean>>({});+// Usage example when toggling:+const toggleSelectAll = (tableIndex: number, value: boolean) => {+ setIsAllSelectedMap(prev => ({ ...prev, [tableIndex]: value }));+};
Suggestion importance[1-10]: 8
__
Why: The use of a single isAllSelected boolean will cause state conflicts across multiple tables; tracking per table prevents this critical bug.
Medium
Reset counters per table
Reset the column counters inside each table iteration instead of accumulating across all tables. This ensures the "all selected" check is per-table and not global.
Why: Declaring counters outside the loop accumulates counts across all tables, so resetting them inside each iteration is necessary for accurate per-table "all selected" checks.
Medium
Possible issue
Ensure toggle state updated
Add an else branch to reset the "select all" state when not all columns are selected. Without it, unchecking a column will leave the checkbox checked incorrectly.
Bulk "Select All"/deselect all checkbox in Data Import Flow for table columns
Automatic alias count updates when toggling column selection
to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes Made
How to Test
Notes