773 chipblock linkbug

[SindhuHarika]

Description

Implemented the navigation for link option of chip block

Changes Made

Implemented the navigation for link option of chip block

[github-actions]

@CodiumAI-Agent /describe

[QodoAI-Agent]

Title

773 chipblock linkbug

---

User description

Description

Implemented the navigation for link option of chip block

Changes Made

Implemented the navigation for link option of chip block

---

PR Type

Bug fix

---

Description

• Enable chip link to open in new tab

• Prevent default navigation before opening

• Use noopener,noreferrer for security

---

Changes walkthrough 📝

	Relevant files
Enhancement	ChipBlock.tsx Enhance chip link click behavior                                                  libs/renderer/src/components/block-defaults/chip-block/ChipBlock.tsx Replaced simple e.preventDefault() handler Added window.open(link, '_blank', 'noopener,noreferrer') Ensured link opens in new tab securely +1/-1

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[github-actions]

@CodiumAI-Agent /review

[github-actions]

@CodiumAI-Agent /improve

[QodoAI-Agent]

PR Code Suggestions ✨

Latest suggestions up to 383d8b7

Category	Suggestion	Impact
Security	Add noopener noreferrer rel Add a rel="noopener noreferrer" attribute to any anchor using target="_blank" to prevent reverse tabnabbing attacks. This ensures the new page cannot access your window object. libs/renderer/src/components/block-defaults/chip-block/ChipBlock.tsx [141] -<a href={link} target="_blank"> +<a href={link} target="_blank" rel="noopener noreferrer"> Suggestion importance[1-10]: 8 __ Why: Adding rel="noopener noreferrer" prevents reverse tabnabbing and is a best practice when using target="_blank" for security.	Medium

---

Previous suggestions

Suggestions up to commit 8d53e62

Category	Suggestion	Impact
Security	Use anchor target and rel Replace the manual window.open call and preventDefault handler with native anchor attributes for opening a new tab securely and remove the inline click handler. This improves accessibility and simplifies the code. libs/renderer/src/components/block-defaults/chip-block/ChipBlock.tsx [141-146] -<a href={link}> - <Chip - {...chipProps} - onClick={(e) => {e.preventDefault();window.open(link, '_blank','noopener,noreferrer')}} - /> +<a href={link} target="_blank" rel="noopener noreferrer"> + <Chip {...chipProps} /> </a> Suggestion importance[1-10]: 7 __ Why: Using native target="_blank" and rel="noopener noreferrer" simplifies the code, improves security and accessibility, and removes unnecessary inline JS.	Medium
Possible issue	Guard against undefined link Add a guard to ensure link is defined before calling window.open to avoid runtime errors when link is undefined or empty. libs/renderer/src/components/block-defaults/chip-block/ChipBlock.tsx [144] -onClick={(e) => {e.preventDefault();window.open(link, '_blank','noopener,noreferrer')}} +onClick={(e) => { + e.preventDefault(); + if (!link) return; + window.open(link, '_blank', 'noopener,noreferrer'); +}} Suggestion importance[1-10]: 5 __ Why: Adding a check for undefined link prevents runtime errors but has minor impact on functionality.	Low

[anurag91jain]

why does the Chip need an onClick when there is an anchor tag wrapping it? can't we get rid of the onClick on the chip altogether and use the anchor tag?

[johbaxter]

@Mezzet link on chip fix, take a look at code

[github-actions]

@CodiumAI-Agent /update_changelog

[QodoAI-Agent]

Changelog updates: 🔄

2025-05-27 #1195

Added

• navigation support for chip block link option, opening links in a new tab

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'