feat(client): after adding member, admin doesn't turn off

[pallabi2303]

Description

feat(client): after adding member, admin doesn't turn off

Changes Made

After Adding user, the page doesn't get refreshed automatically. So, 'Admin On' remains as it is.

How to Test

1. Log in as an Admin.
2. Navigate to the Members settings page for an app or engine that user don't have an access for.
3. On 'Admin On', Add Member.
4. User can see that after Member being added Admin remains on.

[github-actions]

@CodiumAI-Agent /describe

[QodoAI-Agent]

Title

feat(client): after adding member, admin doesn't turn off

---

User description

Description

feat(client): after adding member, admin doesn't turn off

Changes Made

After Adding user, the page doesn't get refreshed automatically. So, 'Admin On' remains as it is.

How to Test

1. Log in as an Admin.
2. Navigate to the Members settings page for an app or engine that user don't have an access for.
3. On 'Admin On', Add Member.
4. User can see that after Member being added Admin remains on.

---

PR Type

Bug fix

---

Description

• Deleted window.location.reload on success

• Ensures overlay closes without refresh

---

Changes walkthrough 📝

	Relevant files
Bug fix	MembersAddOverlay.tsx Remove page reload logic after adding member                          packages/client/src/components/settings/MembersAddOverlay.tsx Removed window.location.reload in finally block Streamlined overlay close without page refresh +0/-4

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[github-actions]

@CodiumAI-Agent /review

[QodoAI-Agent]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Missing UI refresh The auto-reload after successfully adding a member was removed, but there is no alternative state update or data fetching to refresh the members list or admin status in the UI. } finally { // close the overlay closeOverlay(type, success); } }; Stale admin status Without reloading or updating the component state, the 'Admin On' label may remain unchanged and confuse users about current permissions. } finally { // close the overlay closeOverlay(type, success); } };

[github-actions]

@CodiumAI-Agent /improve

[QodoAI-Agent]

PR Code Suggestions ✨

Category	Suggestion	Impact
General	Trigger member list refresh Instead of reloading the entire window to show updated by/timestamps, call a member‐list refetch or update function after closing the overlay. This will refresh just the data you need without a full page reload. packages/client/src/components/settings/MembersAddOverlay.tsx [471] closeOverlay(type, success); +props.refetchMembers(); Suggestion importance[1-10]: 7 __ Why: Adding a targeted props.refetchMembers() avoids a full page reload and efficiently updates the member list, improving UX and performance without major risk.	Medium
	Reset admin toggle state Reset the admin toggle state after a successful add so that the switch isn’t left on for the next addition. Call your state setter (e.g. setIsAdmin(false)) immediately after closing. packages/client/src/components/settings/MembersAddOverlay.tsx [471] closeOverlay(type, success); +setIsAdmin(false); Suggestion importance[1-10]: 5 __ Why: Clearing the admin toggle with setIsAdmin(false) prevents unintended state carry-over, but it’s a minor UI convenience and not critical to core functionality.	Low

[pallabi2303]

@ishumita
You mentioned you have added the refresh so that the updated by and timestamp show up, but even if we don't refresh the page it is already behaving like that. So, I have removed the refresh as the Admin was turning off because of it, and we were getting error.

[QodoAI-Agent]

PR Code Suggestions ✨

No code suggestions found for the PR.

[ishumita]

@pallabi2303 sure, thank you for letting me know:)

[github-actions]

@CodiumAI-Agent /update_changelog

[QodoAI-Agent]

Changelog updates: 🔄

2025-05-28 *

Fixed

• Stop automatic page reload after adding a member so the admin toggle state persists.

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'