Skip to content

feat(client): fixing Workspace error#1311

Merged
neelneelneel merged 1 commit intodevfrom
1310-error-screen-when-clicking-edit-on-user-application-on-workshop-dev
Jun 17, 2025
Merged

feat(client): fixing Workspace error#1311
neelneelneel merged 1 commit intodevfrom
1310-error-screen-when-clicking-edit-on-user-application-on-workshop-dev

Conversation

@neelneelneel
Copy link
Copy Markdown
Contributor

Description

Changes Made

How to Test

  1. Steps to reproduce/test the behavior
  2. Expected outcomes

Notes

@neelneelneel neelneelneel requested a review from a team as a code owner June 17, 2025 18:58
@neelneelneel neelneelneel linked an issue Jun 17, 2025 that may be closed by this pull request
3 tasks
@github-actions
Copy link
Copy Markdown

@CodiumAI-Agent /describe

@QodoAI-Agent
Copy link
Copy Markdown

Title

feat(client): fixing Workspace error


User description

Description

Changes Made

How to Test

  1. Steps to reproduce/test the behavior
  2. Expected outcomes

Notes


PR Type

Bug fix


Description

  • Remove unused notebook hook import

  • Enable persistent drawer variant


Changes walkthrough 📝

Relevant files
Bug fix
Workspace.tsx
Cleanup and enable persistent drawer                                         

packages/client/src/components/workspace/Workspace.tsx

  • Deleted unused notebook destructuring
  • Uncommented variant="persistent" on Drawer
  • +1/-3     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @github-actions
    Copy link
    Copy Markdown

    @CodiumAI-Agent /review

    @QodoAI-Agent
    Copy link
    Copy Markdown

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Removal Side-effect

    The removal of const { notebook } = useBlocks() may cause undefined references or break parts of Workspace relying on notebook. Verify no remaining usages of notebook and that useBlocks is not needed.

    export const Workspace = observer((props: WorkspaceProps) => {
        const {
            endTopbar = null,
            alert,
            footer = null,
            workspace,
            options,
            factory = () => null,
        } = props;
        const { configStore } = useRootStore();
    
        const layoutRef = useRef<Layout>(null);
    
        // const [model, setModel] = useState<Model | null>(null);
    Drawer Configuration

    Adding variant="persistent" changes the drawer behavior. Ensure the layout accounts for persistent drawers (e.g., content resizing) and that variant is supported by the imported Drawer component.

    <Drawer
        anchor="left"
        variant="persistent"
        open={workspace.drawer.isOpen}

    @github-actions
    Copy link
    Copy Markdown

    @CodiumAI-Agent /improve

    @neelneelneel neelneelneel merged commit 192b8d9 into dev Jun 17, 2025
    4 checks passed
    @neelneelneel neelneelneel deleted the 1310-error-screen-when-clicking-edit-on-user-application-on-workshop-dev branch June 17, 2025 19:00
    @github-actions
    Copy link
    Copy Markdown

    @CodiumAI-Agent /update_changelog

    @QodoAI-Agent
    Copy link
    Copy Markdown

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @QodoAI-Agent
    Copy link
    Copy Markdown

    Changelog updates: 🔄

    2025-06-17 *

    Fixed

    • Prevent workspace error when clicking edit on a user application by restoring persistent drawer variant

    to commit the new content to the CHANGELOG.md file, please type:
    '/update_changelog --pr_update_changelog.push_changelog_changes=true'

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    Error Screen when Clicking Edit on User Application on Workshop Dev

    2 participants