Skip to content

869 scatter plot#1506

Merged
johbaxter merged 18 commits intodevfrom
869-scatter-plot
Aug 21, 2025
Merged

869 scatter plot#1506
johbaxter merged 18 commits intodevfrom
869-scatter-plot

Conversation

@RNubla
Copy link
Copy Markdown
Contributor

@RNubla RNubla commented Jul 14, 2025

Description

Changes Made

  • create customRenderHook to be able to reflect changes made via useBlock
  • create test cases for scatter plot

How to Test

  1. pnpm run test

Notes

RNubla added 17 commits June 16, 2025 15:13
@RNubla
test(renderer): cherry pick testing/index so that scatter plot can be…
c8dd19f 
… tested
@RNubla
test(renderer): implement scatter plot test
d469b3d
@RNubla
test(renderer): add tooltip test cases
36066ea
@RNubla
Merge branch 'dev' into 869-scatter-plot
b4e70c9
@RNubla
test(renderer): add test case for setting data for scatter plot
f42b2fe
@RNubla
test(renderer): remove bad label data
22f987a
@RNubla
test(renderer): add test cases for scatter plot size dimension
0fcebcf
@RNubla
Merge branch 'dev' into 869-scatter-plot
d7ac83f
@RNubla
test(renderer): added test case for updating x-axis
99aeee0
@RNubla
test(renderer): add test case to update font size
b009fa3
@RNubla
test(renderer): implementing Show/Hide X axis test
13e37d0
@RNubla
test(renderer): implementing test for Show/Hide Axis toggle
dcd43ef
@RNubla
test(renderer): fixed formatting
8afa318
@RNubla
test(renderer): implement test case for Show/Hide axis toggle is true…
8ad3526 
… by default
@RNubla
test(renderer): implement test case for Show/Hide Axis toggle to be c…
6b96edc 
…licked and toggled off
@RNubla
test(renderer): implement test case for Show Axis Title Toggle
2aa2944
@RNubla
test(renderer): implement test to set X Axis Title
9432734
@RNubla RNubla requested a review from a team as a code owner July 14, 2025 16:32
@RNubla RNubla linked an issue Jul 14, 2025 that may be closed by this pull request
Scatter Plot #869
Closed
@RNubla RNubla requested a review from memisrose July 14, 2025 16:34
johbaxter
johbaxter approved these changes Aug 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@johbaxter johbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this actually works, but will push test. If we have failed test, test team should fix. But will push for the purpose of adding the test file

@johbaxter johbaxter merged commit 479fd69 into dev Aug 21, 2025
3 checks passed
@johbaxter johbaxter deleted the 869-scatter-plot branch August 21, 2025 21:10
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 21, 2025

@CodiumAI-Agent /update_changelog

@QodoAI-Agent
Copy link
Copy Markdown

QodoAI-Agent commented Aug 21, 2025

Changelog updates: 🔄

2025-08-21 *

Added

  • Scatter plot test coverage, including tooltip, axis visibility, title, sizing, and font settings
  • Custom render hook support to reflect useBlock updates in tests

Changed

  • Testing utilities adjusted to pass render engine ID automatically

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johbaxter johbaxter johbaxter approved these changes

@memisrose memisrose Awaiting requested review from memisrose

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Scatter Plot

4 participants

@RNubla @QodoAI-Agent @johbaxter @memisrose