1439 load state container markdown text blocks#1548
1439 load state container markdown text blocks#1548bannaarisamy-shanmugham-kanini wants to merge 20 commits intodevfrom
Conversation
|
@CodiumAI-Agent /describe |
|
@CodiumAI-Agent /review |
Title1439 load state container markdown text blocks User descriptionDescriptionadding a load state setting on Container, Text and markdown blocks where it will have loading and Load Skeleton fields. Changes MadeAdded new Section named Load state under Container, Markdown and Text blocks block setting. How to Test
NotesPR TypeEnhancement Description
Diagram Walkthroughflowchart LR
A["BlockData.loading & loadSkeleton"] --> B["Check isLoading"]
B -- "true" --> C["Render LoadingSkeleton or Trigger"]
B -- "false" --> D["Render actual block content"]
|
| Relevant files |
|---|
|
@CodiumAI-Agent /improve |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to f0214a9
Previous suggestionsSuggestions up to commit a124d23
|
|
@bannaarisamy-shanmugham-kanini please fix the merge conflicts. I would like this to get in tomorrow. |
…oad-state-container-markdown-text-blocks
…oad-state-container-markdown-text-blocks
…oad-state-container-markdown-text-blocks
|
Hi @Abhisheksaini129QA , I have committed all my changes and please validate my PR and let me know if any further changes are needed. |
…oad-state-container-markdown-text-blocks
|
Hi @bannaarisamy-shanmugham-kanini , i have tested the above task , here is my observation
|
…oad-state-container-markdown-text-blocks
johbaxter
left a comment
There was a problem hiding this comment.
Im taking this on and will use some of your code.
Where is the migration manager to add this property to all blocks
|
Closed with: #1745 |
Description
adding a load state setting on Container, Text and markdown blocks where it will have loading and Load Skeleton fields.
loading will feature a loading state of the blocks, and load skeleton will show selected skeleton, when the block is loading.
Changes Made
Added new Section named Load state under Container, Markdown and Text blocks block setting.
How to Test
Notes