Skip to content

feat(renderer): Notebook cell type math fix with output type#1572

Merged
johbaxter merged 9 commits intodevfrom
1566-Notebook-cell-type-match-output-fix
Jul 23, 2025
Merged

feat(renderer): Notebook cell type math fix with output type#1572
johbaxter merged 9 commits intodevfrom
1566-Notebook-cell-type-match-output-fix

Conversation

@Paulson-Robert
Copy link
Copy Markdown
Contributor

@Paulson-Robert Paulson-Robert commented Jul 22, 2025

Description

Pushed multiple bug fix code into this branch/PR

  1. 1566 - Notebook cell type does not match JSON output Type
  2. 386 - Catalog Creation Form Disable Submit

Changes Made

**1566 changes : ** > commit

  • Remove frame type Pixel and R
  • Ensured when Python is selected a Py frame is created
  • Ensured when Grid is selected, a Grid frame is created
  • Ensured when Native is selected, a Native frame is created

**386 changes : ** > commit

  • Added parameter > formState: {isValid} and useForm mode as onSubmit to the react-hook-form lib usage.
  • Appended the isValid flag to the submit button disabled validation.

1575 changes > commit

  • Removed the "500" from the pagination option list.

How to Test

1566 repo steps

  1. On a drag-and-drop application, create a new Notebook
  2. Select the data import option under a new cell
  3. Import all columns from any existing Database
  4. Select frame type as "Pixel" and execute
  5. Note the type value of the JSON output as shown:

386 repo steps

  1. Go to catalog creation form page
  2. Verify the submit button is initially disabled
  3. Fill up the required fields and verify the submit button to be enabled

1575 repo steps

  • Create a new Data Grid block inside a Drag and Drop
  • Import a large amount of data using the Import Data from a notebook cell
  • The 500 option for pagination will not show up anymore.

Notes

Fix video links :

@Paulson-Robert Paulson-Robert requested a review from a team as a code owner July 22, 2025 11:39
@Paulson-Robert Paulson-Robert linked an issue Jul 22, 2025 that may be closed by this pull request
8 tasks
@github-actions
Copy link
Copy Markdown

@CodiumAI-Agent /describe

@QodoAI-Agent
Copy link
Copy Markdown

Title

feat(renderer): Notebook cell type math fix with output type


User description

… cell

Description

Changes Made

  • Remove frame type Pixel and R
  • Ensured when Python is selected a Py frame is created
  • Ensured when Grid is selected, a Grid frame is created
  • Ensured when Native is selected, a Native frame is created

How to Test

  1. On a drag-and-drop application, create a new Notebook
  2. Select the data import option under a new cell
  3. Import all columns from any existing Database
  4. Select frame type as "Pixel" and execute
  5. Note the type value of the JSON output as shown:

Notes


PR Type

Bug fix


Description

  • Removed PIXEL and R frame types

  • Updated NATIVE display label to Native

  • Retained only PY and GRID frame types


File Walkthrough

Relevant files
Bug fix
DataImportCell.tsx
Update FRAME_TYPES in DataImportCell                                         

libs/renderer/src/components/cell-defaults/data-import-cell/DataImportCell.tsx

  • Deleted PIXEL and R entries from FRAME_TYPES
  • Adjusted NATIVE display label to "Native"
  • Ensured only PY and GRID remain
+4/-12   

@github-actions
Copy link
Copy Markdown

@CodiumAI-Agent /review

@github-actions
Copy link
Copy Markdown

@CodiumAI-Agent /improve

@QodoAI-Agent
Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Breaking Change

Removal of PIXEL and R frame types may affect existing notebooks or downstream logic; ensure migration or fallback paths are in place.

    PY: {
        display: "Python",
        value: "PY",
    },
    GRID: {
        display: "Grid",
        value: "GRID",
    },
    NATIVE: {
        display: "Native",
        value: "NATIVE",
    },
};
Missing Tests

No unit or integration tests added for the new Native frame type or to validate removal of Pixel and R; tests should cover key behaviors.

    NATIVE: {
        display: "Native",
        value: "NATIVE",
    },
};
Consumer Consistency

Verify that all consumers (dropdowns, JSON serializers, UI components) properly handle the updated FRAME_TYPES, especially the new Native type.

    PY: {
        display: "Python",
        value: "PY",
    },
    GRID: {
        display: "Grid",
        value: "GRID",
    },
    NATIVE: {
        display: "Native",
        value: "NATIVE",
    },
};

@QodoAI-Agent
Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@Paulson-Robert Paulson-Robert self-assigned this Jul 22, 2025
@Paulson-Robert Paulson-Robert linked an issue Jul 23, 2025 that may be closed by this pull request
1 task
@Paulson-Robert Paulson-Robert linked an issue Jul 23, 2025 that may be closed by this pull request
3 tasks
@johbaxter johbaxter merged commit 82b520d into dev Jul 23, 2025
3 checks passed
@johbaxter johbaxter deleted the 1566-Notebook-cell-type-match-output-fix branch July 23, 2025 20:17
@github-actions
Copy link
Copy Markdown

@CodiumAI-Agent /update_changelog

@QodoAI-Agent
Copy link
Copy Markdown

Changelog updates: 🔄

2025-07-23 *

Added

  • exported unified DATA_FRAME_TYPES in SDK

Changed

  • import cells now use SDK frame types; removed deprecated types and synced output
  • default grid pagination options updated

Fixed

  • submit button disabled until form validation passes

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pagination in Data Grid Block Catalog Creation Form Disable Submit Notebook cell type does not match JSON output Type

3 participants