You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
flowchart LR
A["AddAppCloneModal"] -->|buttonTitle: \"Clone\"| C["SaveAppModal"]
B["AddAppModal"] -->|buttonTitle: \"Upload\"| C
C["SaveAppModal"] -->|uses buttonTitle on last step| D["Next Button Label"]
The new buttonTitle prop is required, but there's no default value. If SaveAppModal is used elsewhere without passing this prop, nextStepLabel may render undefined on the final step. Consider providing a default value in the prop destructuring or defining a defaultProp.
Add a fallback in the ternary to guard against an empty or undefined buttonTitle at runtime. This protects against missing or empty strings and keeps the button label meaningful.
Why: Introducing a fallback for buttonTitle improves runtime safety, but the prop is mandatory by type and always passed in this PR, so the benefit is marginal and the 'Upload' default may not always be appropriate.
Low
Add default button title
Provide a default for buttonTitle in the destructuring so it never ends up undefined if a consumer forgets to pass it. This ensures that nextStepLabel always has a valid string fallback.
Why: Providing a default buttonTitle is redundant since the prop is already required and explicitly passed in both call sites, and the hardcoded 'Upload' fallback could be misleading for other uses.
Support custom submitBtnText prop in SaveAppModal and apply to clone/upload modals
Update default action button titles to “Clone” and “Upload”
Refactor button title props and related renderer components
to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes Made
How to Test
Notes