Skip to content

Date and Time Picker Image Update#1602

Merged
johbaxter merged 6 commits intodevfrom
1560_data_and_timepicker_image_update
Aug 4, 2025
Merged

Date and Time Picker Image Update#1602
johbaxter merged 6 commits intodevfrom
1560_data_and_timepicker_image_update

Conversation

@KirthikaKumar-K
Copy link
Copy Markdown
Contributor

Description

Update images for Date and Time Picker

Changes Made

Images are updated for date and time picker blocks

@KirthikaKumar-K KirthikaKumar-K requested a review from a team as a code owner July 28, 2025 13:27
@KirthikaKumar-K KirthikaKumar-K linked an issue Jul 28, 2025 that may be closed by this pull request
3 tasks
@github-actions
Copy link
Copy Markdown

@CodiumAI-Agent /describe

@QodoAI-Agent
Copy link
Copy Markdown

Title

Date and Time Picker Image Update


User description

Description

Update images for Date and Time Picker

Changes Made

Images are updated for date and time picker blocks


PR Type

Enhancement


Description

  • Export new date picker active and hover images

  • Update default menu to include date picker block

  • Add inline comments for clarity in menu file


Diagram Walkthrough

flowchart LR
  A["index.ts: export date picker images"] 
  B["default-menu.ts: include date picker block"]
  A -- "provides assets to" --> B
Loading

File Walkthrough

Relevant files
Configuration changes
index.ts
Export date picker images                                                               

packages/client/src/assets/blocks/index.ts

  • Added DATE_PICKER_ACTIVE export
  • Added DATE_PICKER_HOVER export
+2/-0     
Enhancement
default-menu.ts
Update default menu with date picker                                         

packages/client/src/components/blocks-workspace/menus/default-menu.ts

  • Included date picker in default menu
  • Added explanatory inline comments
+2858/-2871

@github-actions
Copy link
Copy Markdown

@CodiumAI-Agent /review

@github-actions
Copy link
Copy Markdown

@CodiumAI-Agent /improve

@QodoAI-Agent
Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Inconsistent Filename

The new imports reference files with spaces in their names (Date Picker_Active.png / Date Picker_Hover.png), which deviates from the project's naming conventions and may cause bundling or resolution issues. Consider renaming to use underscores or camel case consistently.

export { default as DATE_PICKER_ACTIVE } from './Date Picker_Active.png';
export { default as DATE_PICKER_HOVER } from './Date Picker_Hover.png';
Asset Availability

Ensure that the date picker image files are actually present in the assets directory with matching names and casing. Missing or mismatched files will lead to runtime errors.

export { default as DATE_PICKER_ACTIVE } from './Date Picker_Active.png';
export { default as DATE_PICKER_HOVER } from './Date Picker_Hover.png';

@QodoAI-Agent
Copy link
Copy Markdown

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Impact
General
Remove spaces from asset filenames

Avoid having spaces in asset filenames as they can break import resolution or
linters. Rename the files to use underscores or hyphens and update the import paths
accordingly.

packages/client/src/assets/blocks/index.ts [85-86]

-export { default as DATE_PICKER_ACTIVE } from './Date Picker_Active.png';
-export { default as DATE_PICKER_HOVER } from './Date Picker_Hover.png';
+export { default as DATE_PICKER_ACTIVE } from './Date_Picker_Active.png';
+export { default as DATE_PICKER_HOVER } from './Date_Picker_Hover.png';
Suggestion importance[1-10]: 7

__

Why: Renaming Date Picker_Active.png and Date Picker_Hover.png to remove spaces prevents import resolution issues and linting errors in asset paths.

Medium

@johbaxter johbaxter merged commit be245eb into dev Aug 4, 2025
3 checks passed
@johbaxter johbaxter deleted the 1560_data_and_timepicker_image_update branch August 4, 2025 20:01
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 4, 2025

@CodiumAI-Agent /update_changelog

@QodoAI-Agent
Copy link
Copy Markdown

Changelog updates: 🔄

2025-08-04 *

Changed

  • Updated images for date and time picker blocks.

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Datepicker and Timepicker Block Images

3 participants