Skip to content

feat(build): updating ignore list and adding build date to pom.properties#1603

Merged
themaherkhalil merged 1 commit intodevfrom
pom-update
Jul 28, 2025
Merged

feat(build): updating ignore list and adding build date to pom.properties#1603
themaherkhalil merged 1 commit intodevfrom
pom-update

Conversation

@themaherkhalil
Copy link
Copy Markdown
Contributor

No description provided.

@themaherkhalil themaherkhalil requested a review from a team as a code owner July 28, 2025 15:08
@github-actions
Copy link
Copy Markdown

@CodiumAI-Agent /describe

@QodoAI-Agent
Copy link
Copy Markdown

Title

feat(build): updating ignore list and adding build date to pom.properties


PR Type

Enhancement


Description

  • Update <sourceDirectory> to packages

  • Add maven-antrun-plugin generating build date

  • Refine warSourceExcludes and packagingExcludes

  • Replace sdk excludes with new package paths


Diagram Walkthrough

flowchart LR
  A["pom.xml"]
  B["Update sourceDirectory to packages"]
  C["Add maven-antrun-plugin for build date"]
  D["Refine warSourceExcludes and packagingExcludes"]
  A -- "change" --> B
  A -- "add plugin" --> C
  A -- "update excludes" --> D
Loading

File Walkthrough

Relevant files
Enhancement
pom.xml
Update build and war plugin configuration                               

pom.xml

  • Source directory changed to packages
  • Added maven-antrun-plugin executions
  • Wrote pom.properties with build.date
  • Updated war plugin exclude patterns
+81/-9   

@github-actions
Copy link
Copy Markdown

@CodiumAI-Agent /review

@github-actions
Copy link
Copy Markdown

@CodiumAI-Agent /improve

@QodoAI-Agent
Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

SourceDirectory Change

Ensure that the updated <sourceDirectory> points to an existing packages directory matching your project structure; otherwise, the build will fail.

<sourceDirectory>packages</sourceDirectory>
Plugin Configuration

The maven-antrun-plugin is duplicated across profiles; consider centralizing it and verify that the <target> path correctly uses the intended ${project.build.outputDirectory} or directory structure.

					<plugin>
						<groupId>org.apache.maven.plugins</groupId>
						<artifactId>maven-antrun-plugin</artifactId>
						<version>3.1.0</version>
						<executions>
							<execution>
								<phase>process-resources</phase>
								<goals>
									<goal>run</goal>
								</goals>
								<configuration>
									<target>
   									<mkdir dir="${basedir}/WEB-INF/classes/META-INF/maven/${project.groupId}/${project.artifactId}"/>
										<tstamp>
											<format property="build.timestamp.utc" pattern="yyyy-MM-dd HH:mm:ss z" timezone="UTC" />
										</tstamp>
    									<propertyfile file="${basedir}/WEB-INF/classes/META-INF/maven/${project.groupId}/${project.artifactId}/pom.properties">
											<entry key="groupId" value="${project.groupId}" />
											<entry key="artifactId" value="${project.artifactId}" />
											<entry key="version" value="${project.version}" />
											<entry key="ci.version" value="${project.version}" />
											<entry key="build.date" value="${build.timestamp.utc}" />
										</propertyfile>
									</target>
								</configuration>
							</execution>
						</executions>
					</plugin>
Exclude Patterns

Verify the new warSourceExcludes and packagingExcludes patterns do not unintentionally exclude required modules in packages/.

.github/,
.nx/,
.turbo/,
.m2/,
.husky/,
.vscode/,
**/node_modules,
**/node_modules/**,
packages/cli/,
packages/example/,
packages/vscode-extension/,

@QodoAI-Agent
Copy link
Copy Markdown

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Impact
General
Consolidate plugin configuration

Avoid duplicating the same maven-antrun-plugin configuration in multiple profiles by
moving it into a shared section. This DRYs up the POM and makes maintenance easier.

pom.xml [62-90]

-<plugin>
-    <groupId>org.apache.maven.plugins</groupId>
-    <artifactId>maven-antrun-plugin</artifactId>
-    <version>3.1.0</version>
-    <executions>...</executions>
-</plugin>
+<pluginManagement>
+  <plugins>
+    <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-antrun-plugin</artifactId>
+        <version>3.1.0</version>
+        <executions>...</executions>
+    </plugin>
+  </plugins>
+</pluginManagement>
Suggestion importance[1-10]: 7

__

Why: Consolidating the duplicated maven-antrun-plugin into pluginManagement is a valid DRY improvement but is optional and has moderate impact.

Medium
Standardize timestamp format

Use a strict ISO 8601 timestamp format (e.g. including “T” and “Z”) to ensure
consistency and easier parsing in downstream tools.

pom.xml [75-77]

 <tstamp>
-    <format property="build.timestamp.utc" pattern="yyyy-MM-dd HH:mm:ss z" timezone="UTC" />
+    <format property="build.timestamp.utc" pattern="yyyy-MM-dd'T'HH:mm:ss'Z'" timezone="UTC" />
 </tstamp>
Suggestion importance[1-10]: 5

__

Why: Switching to an ISO 8601 format improves downstream parsing consistency, but it’s a minor, non-critical enhancement.

Low
Clean up exclude patterns

Remove trailing commas and use wildcard directory patterns to ensure excludes are
applied correctly without literal commas. List entries should be newline-separated
without commas, and nested directories should use
patterns.**

pom.xml [98-114]

 <warSourceExcludes>
-    .gitlab/,
-    .gitlab-ci.yml,
-    .github/,
-    .nx/,
-    .turbo/,
-    **/node_modules,
-    **/node_modules/**,
+    .gitlab/
+    .gitlab-ci.yml
+    .github/**
+    .nx/**
+    .turbo/**
+    **/node_modules/**
     ...
 </warSourceExcludes>
Suggestion importance[1-10]: 3

__

Why: The improved snippet is incomplete and deviates from Maven’s expected format, making this a low-impact and error-prone change.

Low

@themaherkhalil themaherkhalil merged commit cbdb4eb into dev Jul 28, 2025
4 checks passed
@themaherkhalil themaherkhalil deleted the pom-update branch July 28, 2025 15:31
@github-actions
Copy link
Copy Markdown

@CodiumAI-Agent /update_changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants