Fix HMR for Client Dependency Packages#1612
Conversation
…ependencies build before client
|
@CodiumAI-Agent /describe |
TitleFix HMR for Client Dependency Packages User descriptionDescriptionThis pull request fixes an issue requiring packages to be individually built in order to show changes made within. For example, the platform team has been working within This pull request ensures that Changes Made
How to Test
Notes
PR TypeBug fix Description
Diagram Walkthroughflowchart LR
dev["turbo run dev (dev task)"]
builddev["build:dev task"]
deps["Dependency packages"]
dev -- "dependsOn" --> builddev
builddev -- "^build:dev" --> deps
|
| Relevant files | |||
|---|---|---|---|
| Formatting |
| ||
| Configuration changes |
|
|
@CodiumAI-Agent /review |
|
@CodiumAI-Agent /improve |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨
|
|
@CodiumAI-Agent /update_changelog |
Description
This pull request fixes an issue requiring packages to be individually built in order to show changes made within. For example, the platform team has been working within
libs/renderer, and has been unable to view changes to their code without navigating to the renderer package and running the build script. This was especially problematic because they were reporting build times exceeding 7 minutes.This pull request ensures that
turbo build:devis run on all dependency packages of the package runningturbo run dev. This ensures that when the client's Vite dev server starts, all the libraries it imports (UI components, renderer, SDK) are already built and available in their dist folders, and thus enables HMR for all dependent packages once the initial dev script has completed.Changes Made
dependsOn: ["^build:dev"]to dev script in turbo.jsonHow to Test
pnpm run dev:clientfrom the root (SemossWeb/semoss-ui depending on your path configuration).Notes
pnpm run devwill result in the playground running on port 5174 and the client not running at all. I'll propose this change in a subsequent PR as well.