Skip to content

feat(client): catalog create button disable issue fix#1820

Merged
johbaxter merged 1 commit intodevfrom
441-Create-database-btn-disable-fix
Sep 4, 2025
Merged

feat(client): catalog create button disable issue fix#1820
johbaxter merged 1 commit intodevfrom
441-Create-database-btn-disable-fix

Conversation

@Paulson-Robert
Copy link
Copy Markdown
Contributor

Description

Fixing the catalog create button still disabled issue.

Changes Made

Changes the form mode back to onSubmit from onBlur

How to Test

  1. Navigate to any catalog creation form page
  2. Fill all required fields and verify the create button is getting enabled.

Notes

Caused commit : fcfe3fd
Caused PR : #1768
Ticket : #1691

@Paulson-Robert Paulson-Robert requested a review from a team as a code owner September 4, 2025 10:32
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 4, 2025

@CodiumAI-Agent /describe

@Paulson-Robert Paulson-Robert self-assigned this Sep 4, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 4, 2025

@CodiumAI-Agent /review

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 4, 2025

@CodiumAI-Agent /improve

@QodoAI-Agent
Copy link
Copy Markdown

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Impact
Possible issue
Enable real-time validation

Using "onSubmit" delays validation until submit, which can keep the create button
enabled/disabled in an unexpected state and degrade UX. Switch to "onChange" so
validation state updates as users type, keeping the button state accurate without
extra interactions.

packages/client/src/components/import/ImportForm.tsx [104]

-mode: "onSubmit",
+mode: "onChange",
Suggestion importance[1-10]: 5

__

Why: The suggestion correctly targets the new line mode: "onSubmit", and proposes onChange to improve real-time validation UX; however, this is a subjective UX trade-off and not a clear bug fix, so its impact is moderate.

Low

@johbaxter johbaxter merged commit 9f9fd6a into dev Sep 4, 2025
4 checks passed
@johbaxter johbaxter deleted the 441-Create-database-btn-disable-fix branch September 4, 2025 19:46
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 4, 2025

@CodiumAI-Agent /update_changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The "Create Database" button remains disabled after uploading a ZIP file

3 participants