Skip to content

591 fix remove extra layer on variables in construct and ensure variables can be referenced in#218

Merged
neelneelneel merged 33 commits intodevfrom
591-fix-remove-extra-layer-on-variables-in-construct-and-ensure-variables-can-be-referenced-in
Jul 30, 2024
Merged

591 fix remove extra layer on variables in construct and ensure variables can be referenced in#218
neelneelneel merged 33 commits intodevfrom
591-fix-remove-extra-layer-on-variables-in-construct-and-ensure-variables-can-be-referenced-in

Conversation

@johbaxter
Copy link
Copy Markdown
Contributor

@johbaxter johbaxter commented Jul 24, 2024

How to test:

Step 1.
While on the dev branch, I created old apps based on the apps that were built on workshop dev. I grabbed the json from there and pulled them into my local. Did this for about 10 apps.

Step 2.
Switch to the branch tied to pull request and ensure the old state hits my migration function as intended.

Resolves #18

johbaxter added 25 commits July 9, 2024 17:31
…nstruct-and-ensure-variables-can-be-referenced-in
…nstruct-and-ensure-variables-can-be-referenced-in
@johbaxter johbaxter requested a review from a team as a code owner July 24, 2024 19:24
@johbaxter
Copy link
Copy Markdown
Contributor Author

johbaxter commented Jul 24, 2024

Things that were completed in this PR:
DONE: Migrate old syntax {{block.input-2712.value}}, {{query.python_code.cell.92121.output}}, {{query.python_code.output}} to variables
DONE: variables that are cells --> "queryId": "", "cellId": "", We don't want to do string manipulation to get left and right pointer
DONE: In designer only give variables as options with settings select
DONE: In designer, Selected and Hovered mask show variable name if it is a variable
DONE: rename cell allows creates a variable
DONE: rename block creates a variable
DONE: Fix Migration logic, If old app does not have version it's safe to assume they are at the first version
DONE: Ensure no duplicating variable names, all have to be unique (error message), check the renaming too TODO: TEST
DONE: Ensure periods can't be in alias (will mess with syntax perhaps)
DONE: Migration Manager, if pointer is already in variables don't create a variable just change it to whats already there.

I added a second test migration function that will show that it will run recursively until app is up to date. Just change the current version and you will see the state update.

old-vars.json

@johbaxter johbaxter marked this pull request as draft July 24, 2024 19:28
@johbaxter johbaxter force-pushed the 591-fix-remove-extra-layer-on-variables-in-construct-and-ensure-variables-can-be-referenced-in branch from 3152ac0 to 7993cfc Compare July 25, 2024 16:51
@johbaxter johbaxter marked this pull request as ready for review July 25, 2024 17:01
@neelneelneel neelneelneel merged commit edd869a into dev Jul 30, 2024
@neelneelneel neelneelneel deleted the 591-fix-remove-extra-layer-on-variables-in-construct-and-ensure-variables-can-be-referenced-in branch July 30, 2024 15:16
@neelneelneel
Copy link
Copy Markdown
Contributor

Resolves #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TASK] Fix Variables - reference in designer and fix construct

2 participants