Skip to content

Expand/collapse button state sync up with manual expand/collapse icons#2434

Merged
Paulson-Robert merged 35 commits intodevfrom
557-collapseexpand-all-button-does-not-update-based-on-manual-expandcollapse-actions-for-tables
Feb 27, 2026
Merged

Expand/collapse button state sync up with manual expand/collapse icons#2434
Paulson-Robert merged 35 commits intodevfrom
557-collapseexpand-all-button-does-not-update-based-on-manual-expandcollapse-actions-for-tables

Conversation

@Vishal24-Kanini
Copy link
Copy Markdown
Contributor

Description

Fixed the issue related to synchronization of states between expand/collapse button and individual tables.

Changes Made

  • Derive a live value from the table instead of stale state.
  • Now internal expand Tables is updated synchronously inside the same state update along with toggle state.
  • Also make a minor change in SQLQueryEditor.tsx so the editor border should not collides with outer box
image image

How to Test

  1. Steps to reproduce/test the behavior
  2. Expected outcomes

Notes

…-based-on-manual-expandcollapse-actions-for-tables
…manual-expandcollapse-actions-for-tables' of https://github.com/SEMOSS/semoss-ui into 557-collapseexpand-all-button-does-not-update-based-on-manual-expandcollapse-actions-for-tables
…-based-on-manual-expandcollapse-actions-for-tables
…-based-on-manual-expandcollapse-actions-for-tables
…-based-on-manual-expandcollapse-actions-for-tables
…-based-on-manual-expandcollapse-actions-for-tables
…-based-on-manual-expandcollapse-actions-for-tables
…-based-on-manual-expandcollapse-actions-for-tables
…-based-on-manual-expandcollapse-actions-for-tables
@Vishal24-Kanini Vishal24-Kanini marked this pull request as ready for review January 8, 2026 06:02
@Vishal24-Kanini Vishal24-Kanini requested a review from a team as a code owner January 8, 2026 06:02
…-based-on-manual-expandcollapse-actions-for-tables
…-based-on-manual-expandcollapse-actions-for-tables
…-based-on-manual-expandcollapse-actions-for-tables
…-based-on-manual-expandcollapse-actions-for-tables
…-based-on-manual-expandcollapse-actions-for-tables
…-based-on-manual-expandcollapse-actions-for-tables
…-based-on-manual-expandcollapse-actions-for-tables
…-based-on-manual-expandcollapse-actions-for-tables
…manual-expandcollapse-actions-for-tables' of https://github.com/SEMOSS/semoss-ui into 557-collapseexpand-all-button-does-not-update-based-on-manual-expandcollapse-actions-for-tables
…-based-on-manual-expandcollapse-actions-for-tables
…-based-on-manual-expandcollapse-actions-for-tables
…llapseexpand-all-button-does-not-update-based-on-manual-expandcollapse-actions-for-tables
@Vishal24-Kanini Vishal24-Kanini marked this pull request as draft February 9, 2026 11:30
…-based-on-manual-expandcollapse-actions-for-tables
…-based-on-manual-expandcollapse-actions-for-tables
@Vishal24-Kanini
Copy link
Copy Markdown
Contributor Author

@Paulson-Robert , I have re-fix the issue in the same branch and pushed changes. pls check.

…-based-on-manual-expandcollapse-actions-for-tables
…-based-on-manual-expandcollapse-actions-for-tables
…manual-expandcollapse-actions-for-tables' of https://github.com/SEMOSS/semoss-ui into 557-collapseexpand-all-button-does-not-update-based-on-manual-expandcollapse-actions-for-tables
…-based-on-manual-expandcollapse-actions-for-tables
Copy link
Copy Markdown
Contributor

@Paulson-Robert Paulson-Robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved!

…-based-on-manual-expandcollapse-actions-for-tables
@Vishal24-Kanini Vishal24-Kanini marked this pull request as ready for review February 25, 2026 09:09
Vishal24-Kanini and others added 3 commits February 26, 2026 16:47
…-based-on-manual-expandcollapse-actions-for-tables
…-based-on-manual-expandcollapse-actions-for-tables
…-based-on-manual-expandcollapse-actions-for-tables
@Paulson-Robert Paulson-Robert merged commit 50905e7 into dev Feb 27, 2026
3 checks passed
@Paulson-Robert Paulson-Robert deleted the 557-collapseexpand-all-button-does-not-update-based-on-manual-expandcollapse-actions-for-tables branch February 27, 2026 12:29
@github-actions
Copy link
Copy Markdown

@CodiumAI-Agent /update_changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collapse/Expand All button does not update based on manual expand/collapse actions for tables

2 participants