Conversation
…CP-JSON-Editor-shared-component
…CP-JSON-Editor-shared-component
…b.com/SEMOSS/semoss-ui into 2329-MCP-JSON-Editor-shared-component
…CP-JSON-Editor-shared-component
…b.com/SEMOSS/semoss-ui into 2329-MCP-JSON-Editor-shared-component
…CP-JSON-Editor-shared-component
…CP-JSON-Editor-shared-component
…b.com/SEMOSS/semoss-ui into 2329-MCP-JSON-Editor-shared-component
…CP-JSON-Editor-shared-component
…b.com/SEMOSS/semoss-ui into 2329-MCP-JSON-Editor-shared-component
| saveShortcut = "Ctrl+S / Cmd+S", | ||
| }) => { | ||
| return ( | ||
| <div className="sticky top-0 z-50 mb-6 rounded-lg border border-gray-200 bg-white/95 p-4 backdrop-blur-sm"> |
There was a problem hiding this comment.
Utilize css classes that use theme-tokens. IE "bg-background"
There was a problem hiding this comment.
This is not necessary. See the input-group component
There was a problem hiding this comment.
Why does this need to be it's own component?
There was a problem hiding this comment.
This should not be necessary since it is coming from globals.css
There was a problem hiding this comment.
This shouldn't be its own component. We should use monaco so the json can render correctly
| tools: MCPTool[]; | ||
| }; | ||
|
|
||
| export interface EditorHeaderProps { |
There was a problem hiding this comment.
Keep Props with the component
There was a problem hiding this comment.
Moving each individual type to responsible component will increase duplicate code.
By keeping this in shared types, we are using it in shared component and in parent component as well.
There was a problem hiding this comment.
Why is this different than the one in app-workspace? Can they be merged?
There was a problem hiding this comment.
Yes it can be merged.
Now we have used a single mcp-json-editor.tsx file in /shared
…CP-JSON-Editor-shared-component
…b.com/SEMOSS/semoss-ui into 2329-MCP-JSON-Editor-shared-component
KirthikaKumar-K
force-pushed
the
adapting_ui_mcp
branch
from
7922d78 to
84f2479
Compare
KirthikaKumar-K
force-pushed
the
adapting_ui_mcp
branch
from
4ffae87 to
d1c4814
Compare
|
@CodiumAI-Agent /update_changelog |
4 participants
Description
MCP Json editor refactor
Notes
This PR is dependent on the following PR's:
FE PR:
#2406