505 UI builder notebook add import data to the notebook#254
Merged
Conversation
added 30 commits
May 7, 2024 14:42
…d-import-data-to-the-notebook
…edits and preview
…d-import-data-to-the-notebook
… populate join select
…g tables and submitting
…ck event for all columns
…nd styled tooltips added
…management refactor
added 24 commits
July 3, 2024 17:01
…orking frame variable
…d-import-data-to-the-notebook
…d passing cell data
…les columns and aliases
…d-import-data-to-the-notebook
johbaxter
deleted the
505-ui-builder-notebook-add-import-data-to-the-notebook
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds MVP functionality for Data Import in notebook and new cell type for Data Import. Contained mostly within new Data Import modal component.
Can currently create, edit and delete new Data Import cells from any database user has access to. Columns can be added and aliased from multiple tables via automatic joins determined by edges defined from BE. Preview can be generated and alias conflicts are flagged similar to legacy. After cell is run data is accessible in other cells via the frame variable.
Follows legacy workflow as closely as possible with new designs. Produces viewable pixel that the user can copy, paste and edit in separate pixel cells.
Special attention should be paid to testing join functionality due to local environment issue.
Pixel syntax should be identical to legacy across the board.