Optional theme to disable links to platform from Playground#2804
Merged
Conversation
Contributor
|
@ckelly17 Should this include ability to customize routes if enabled e.g. linking to playground knowledge page |
Contributor
Author
|
@kzsb03 I like that idea. Let's talk about best way to implement |
Contributor
|
@ckelly17 We should default the value to true in the root store, currently not set |
Contributor
Author
|
@kzsb03 updated and confirmed that works as scoped when |
Contributor
|
I don't think this is valid yet. Base platform has functionality that is missing from the playground and is important in understanding the app/engine. |
Contributor
|
I don't think this is valid yet. Base platform has functionality that is missing from the playground and is important in understanding the app/engine. |
|
@CodiumAI-Agent /update_changelog |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR provides a means to hide the various links to the base platform for engines, agents, MCPs, etc. It implements conditional logic set in the theme database to hide these links if desired. If no value is set in theme, links will be shown.
Changes Made
libs/shared/src/types.tsand stored inpackages/playground/src/stores/root/root.store.tsHow to Test
These links appear in four visible spots:
In order to disable these, set
{"showPlatformLinks": false}in theme. Confirm that none of these locations display the links. To test the reverse, either set totrueor have no value forshowPlatformLinksin theme. All links should appear as they currently do.Example Shown (Agent Detail Page)

Example Hidden

Notes
The theme setting
showPlatformLinks: falsehides external links to the SEMOSS platform. It's read directly in each of the 5 components that render such a link, via:root.theme.showPlatformLinks !== falseThe check is duplicated in each file. It works, but if someone adds a new platform link in the future they have to know to add the same check manually.
Possible future approach (not yet implemented, need consensus):
Create a wrapper component in
packages/playground/src/components/common/. It would internally do theshowPlatformLinkscheck and either render an<a target="_blank">or return null. Any new platform link would just use this component instead of a bare<a>, and the gating behavior would come automatically be applied. The convention would be: if the link goes to the SEMOSS platform, use<PlatformLink>.The five existing locations would need to be refactored to use it — that work hasn't been done yet.