fix(client): user engines settings page change issue resolve#296
Merged
neelneelneel merged 1 commit intodevfrom Oct 7, 2024
Merged
fix(client): user engines settings page change issue resolve#296neelneelneel merged 1 commit intodevfrom
neelneelneel merged 1 commit intodevfrom
Conversation
Contributor
Author
|
Any update or Feedback on this ? |
neelneelneel
approved these changes
Oct 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @neelneelneel
I discovered an issue with the user engine settings. Even when clicking on the next page, it still displays page 1. This wasn't the case in the previous build. I've made a minor fix in the
useEffectcall to resolve this. I didn't notice any breaking changes, so I've raised this PR for your review. Please review it before merging.The commit that caused this issue is:
feat(client): updating/refactoring settings
Please let me know if this looks good to merge.