feat(client): issue with value setting for dnd variable fixed#389
Merged
feat(client): issue with value setting for dnd variable fixed#389
Conversation
Contributor
|
Will look at this first thing tomorrow morning @soumya-pratik |
Contributor
|
Please keep in mind other variable types. If a refactor is needed please do so. Also commented on this in an email. |
Contributor
Author
Hey @johbaxter I have updated the code keeping in mind for other variable type. I have done a round of testing for all types variable, please review it. |
Contributor
|
Looks good ty @soumya-pratik |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the issue where value field for variable was not populating with the saved options.