You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Updated SocialProperty state to edit, send and reset data fields.
Changes Made
I removed the useForm in the SocialProperty and updated the fields to point to the state values so that we could track, edit, and submit the updated textField changes.
Updated the reset functionality by adding a refresh functionality that calls the getLoginProperties reactor.
Added error handling for modifyLoginProperties.
How to Test
Go to the settings page
Enter admin mode
Click on configuration
Select any authentication mode
Enter value fields for the data
Click save
Expected outcomes
On the network console, test to see if modifyLoginProperties returns the updated payload values
For the reset functionality, test to see if the textField values reset to the last submitted value.
Notes
I noticed that we have a description text field for each login property, but I don't see a description value key being returned in the getLoginProperties reactor. Should we remove the description text field?
Also, I disabled the login key text field from being edited, but let me know if we want a user to be able to also edit the login key text field as well.
Why: The suggestion correctly identifies a mismatch between the function signature of resetLoginProperties (which takes no parameters) and its usage; updating the call improves consistency and prevents potential runtime errors.
Medium
Prevent state mutation
Avoid direct state mutation by creating a deep clone of the state before modifying it.
Why: The suggestion addresses a significant issue by preventing direct state mutation through cloning the socialProps object, which improves code reliability and adheres to best practices in state management.
Fixed social properties state management and error handling.
Changed configuration UI by removing redundant fields and logic.
to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated SocialProperty state to edit, send and reset data fields.
Changes Made
How to Test
Go to the settings page
Enter admin mode
Click on configuration
Select any authentication mode
Enter value fields for the data
Click save
Expected outcomes
Notes
I noticed that we have a description text field for each login property, but I don't see a description value key being returned in the getLoginProperties reactor. Should we remove the description text field?
Also, I disabled the login key text field from being edited, but let me know if we want a user to be able to also edit the login key text field as well.