Skip to content

Fix classes release #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
themaherkhalil merged 2 commits into from
Mar 8, 2025
Merged

Fix classes release #681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf7c252
fix(cli): adding release=true for custom reactors
themaherkhalil Mar 8, 2025
3a5f4a8
fix(client): adding release=true for custom reactors
themaherkhalil Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/cli/src/commands/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ deploy (./src/commands/deploy.ts)
task: async () => {
// Load the insight classes
await insight.actions.run(
`ReloadInsightClasses('${Env.APP}');`,
`ReloadInsightClasses(project='${Env.APP}', release=true);`,
);

return true;
Expand All @@ -223,7 +223,7 @@ deploy (./src/commands/deploy.ts)
task: async (context) => {
// Publish the app
const { pixelReturn } = await insight.actions.run<[string]>(
`PublishProject('${Env.APP}', release=true);`,
`PublishProject(project='${Env.APP}', release=true);`,
);

// save the url
Expand Down
20 changes: 9 additions & 11 deletions packages/client/src/components/app/AppSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,12 +274,8 @@ export const AppSettings = (props: AppSettingsProps) => {
compiledBy?: string;
}>(
adminMode
? `
AdminGetProjectPortalDetails('${id}');
`
: `
GetProjectPortalDetails('${id}');
`,
? `AdminGetProjectPortalDetails('${id}');`
: `GetProjectPortalDetails('${id}');`,
);

useEffect(() => {
Expand Down Expand Up @@ -350,9 +346,9 @@ export const AppSettings = (props: AppSettingsProps) => {
const recompileReactors = ({ release }) => {
let pixelString;
if (release == null) {
pixelString = `ReloadInsightClasses('${id}');`;
pixelString = `ReloadInsightClasses(project='${id}');`;
} else {
pixelString = `ReloadInsightClasses('${id}', release = true );`;
pixelString = `ReloadInsightClasses(project='${id}', release=true);`;
}

monolithStore
Expand Down Expand Up @@ -397,7 +393,7 @@ export const AppSettings = (props: AppSettingsProps) => {
* @desc Publishes Portal
*/
const publish = () => {
const pixelString = `PublishProject('${id}', release=true);`;
const pixelString = `PublishProject(project='${id}', release=true);`;

monolithStore
.runQuery(pixelString)
Expand Down Expand Up @@ -504,14 +500,16 @@ export const AppSettings = (props: AppSettingsProps) => {
);

// Load the insight classes
await monolithStore.runQuery(`ReloadInsightClasses('${id}');`);
await monolithStore.runQuery(
`ReloadInsightClasses(project='${id}', release=true);`,
);

// set the app portal
await monolithStore.setProjectPortal(false, id, true, 'public');

// Publish the app the insight classes
await monolithStore.runQuery(
`PublishProject('${id}', release=true);`,
`PublishProject(project='${id}', release=true);`,
);

notification.add({
Expand Down