Skip to content

fix(client): modify message for public and discoverable toggle on engine settings #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johbaxter merged 9 commits into from
Mar 17, 2025
Merged

fix(client): modify message for public and discoverable toggle on engine settings #691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
151fa3e
feat(client): create icon block
Mar 5, 2025
73ccf6d
feat(client): create icon block
Mar 10, 2025
5be2914
fix(client): modify message for public and discoverable toggle on eng…
johbaxter Mar 11, 2025
a4b0611
Merge branch '596-icon-block-component' of github.com:SEMOSS/semoss-u…
johbaxter Mar 11, 2025
bea22eb
feat(renderer): add icon block
johbaxter Mar 11, 2025
428d969
Merge branch 'dev' of github.com:SEMOSS/semoss-ui into dev
johbaxter Mar 13, 2025
8543c79
Merge branch 'dev' of github.com:SEMOSS/semoss-ui into dev
johbaxter Mar 14, 2025
32f0b39
Merge branch 'dev' of github.com:SEMOSS/semoss-ui into dev
johbaxter Mar 17, 2025
0602fd0
perf(client): merge
johbaxter Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions packages/client/src/components/settings/SettingsTiles.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,15 +280,18 @@ export const SettingsTiles = (props: SettingsTilesProps) => {

if (response.data.success || response.data) {
setDiscoverable(!discoverable);

notification.add({
color: 'success',
message: `Successfully made ${name} discoverable`,
message: `Successfully made ${name} ${
discoverable ? 'undiscoverable' : 'discoverable'
}`,
});
} else {
notification.add({
color: 'error',
message: `Error making ${name} discoverable`,
message: `Error making ${name} ${
discoverable ? 'undiscoverable' : 'discoverable'
}`,
});
}
} catch (e) {
Expand Down Expand Up @@ -341,12 +344,16 @@ export const SettingsTiles = (props: SettingsTilesProps) => {

notification.add({
color: 'success',
message: `Successfully made ${name} global`,
message: `Successfully made ${name} ${
global ? 'non-global' : 'global'
}`,
});
} else {
notification.add({
color: 'error',
message: `Error making ${name} global`,
message: `Error making ${name} ${
global ? 'non-global' : 'global'
}`,
});
}
} catch (e) {
Expand Down
Loading