Skip to content

feat: added elastic search vector#736

Merged
themaherkhalil merged 3 commits intodevfrom
feature/elastic-search-vector
Mar 27, 2025
Merged

feat: added elastic search vector#736
themaherkhalil merged 3 commits intodevfrom
feature/elastic-search-vector

Conversation

@cdhandar
Copy link
Copy Markdown
Contributor

Description

Feature added Elastic Search Vector
Reordered the display of Vector Databases in alphabetical order

Changes Made

Added JSON Object for Elastic Search in import.constants.ts

How to Test

1.Login
2.Go to Vector
3.Click on Elastic Search
4.Fill out the necessary fields
5.Click on Submit

Notes

While filling the fields make sure you provide either of the two combination API key and ID or Username and Password as it is required for Authentication.

@github-actions
Copy link
Copy Markdown

@CodiumAI-Agent /describe

@QodoAI-Agent
Copy link
Copy Markdown

Title

feat: added elastic search vector


User description

Description

Feature added Elastic Search Vector
Reordered the display of Vector Databases in alphabetical order

Changes Made

Added JSON Object for Elastic Search in import.constants.ts

How to Test

1.Login
2.Go to Vector
3.Click on Elastic Search
4.Fill out the necessary fields
5.Click on Submit

Notes

While filling the fields make sure you provide either of the two combination API key and ID or Username and Password as it is required for Authentication.


PR Type

  • Enhancement

Description

  • Add Elastic Search vector connector fields

  • Update FAISS and PGVector field definitions

  • Refactor Open Search and Pinecone settings

  • Improve configuration validation rules


Changes walkthrough 📝

Relevant files
Enhancement
import.constants.ts
Major update to connectors configuration                                 

packages/client/src/pages/import/import.constants.ts

  • Renamed FAISS to Elastic Search; updated icon and defaults
  • Revised field configurations and validation rules
  • Adjusted PGVector, FAISS, Open Search, and Pinecone settings
  • Reordered and streamlined connector definitions
  • +684/-383

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @github-actions
    Copy link
    Copy Markdown

    @CodiumAI-Agent /review

    @github-actions
    Copy link
    Copy Markdown

    @CodiumAI-Agent /improve

    @QodoAI-Agent
    Copy link
    Copy Markdown

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 5 🔵🔵🔵🔵🔵
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Data Type Consistency

    Several numeric fields (for example, embedding dimension size, EF Construction, and M Value) are defined with string literal default values. Please verify that these fields use the proper numeric types to avoid potential runtime issues.

    {
        fieldName: 'DIMENSION_SIZE',
        label: 'Embedding Dimension Size',
        defaultValue: '1024',
        options: {
            component: 'number',
        },
        disabled: false,
        rules: { required: true, min: 0 },
    Duplicate Definition

    The field "RETAIN_EXTRACTED_TEXT" appears in multiple connection option blocks. Consider consolidating its definition or standardizing its placement to reduce redundancy and possible confusion.

    },
    {
        fieldName: 'RETAIN_EXTRACTED_TEXT',
        label: 'Retain Extracted Text',
        defaultValue: 'false',
        options: {
            component: 'select',
            options: [
                {
                    display: 'False',
                    value: 'false',
                },
                {
                    display: 'True',
                    value: 'true',
                },
            ],
        },
        disabled: false,
        rules: { required: false },
        advanced: true,
    },
    Validation Consistency

    Several new fields (such as API Key, Host Name, and Username) lack consistent helper texts or clear validation messages. Consider adding explanatory helper texts and ensuring that validation rules are uniformly applied for a better user experience.

    {
        fieldName: 'HOSTNAME',
        label: 'Host Name',
        defaultValue: '',
        options: {
            component: 'text-field',
        },
        disabled: false,
        rules: { required: true },
    },
    {

    @QodoAI-Agent
    Copy link
    Copy Markdown

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Use numeric defaults

    Replace empty-string defaults with numeric values for number components.

    packages/client/src/pages/import/import.constants.ts [7822-7832]

     {
                         fieldName: 'FETCH_SIZE',
                         label: 'Fetch Size',
    -                    defaultValue: '',
    +                    defaultValue: 0,
                         rules: { required: false, min: 0 },
                         options: {
                             component: 'number',
                         },
                         disabled: false,
                         advanced: true,
                     }
    Suggestion importance[1-10]: 7

    __

    Why: The suggestion addresses a potential type mismatch by changing the default value from an empty string to a number for a number component, which improves correctness and robustness.

    Medium

    @themaherkhalil themaherkhalil marked this pull request as ready for review March 27, 2025 02:38
    @themaherkhalil themaherkhalil requested a review from a team as a code owner March 27, 2025 02:38
    @themaherkhalil themaherkhalil merged commit d2c515c into dev Mar 27, 2025
    3 checks passed
    @themaherkhalil themaherkhalil deleted the feature/elastic-search-vector branch March 27, 2025 02:57
    @github-actions
    Copy link
    Copy Markdown

    @CodiumAI-Agent /update_changelog

    @QodoAI-Agent
    Copy link
    Copy Markdown

    Changelog updates: 🔄

    2025-03-27

    • Added Elastic Search vector support.
    • Reordered vector database options alphabetically.

    to commit the new content to the CHANGELOG.md file, please type:
    '/update_changelog --pr_update_changelog.push_changelog_changes=true'

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    4 participants