Skip to content

Resolve 'Members Page Search Pagination Bug'#756

Merged
johbaxter merged 1 commit intodevfrom
755-members-page-search-pagination-bug
Apr 4, 2025
Merged

Resolve 'Members Page Search Pagination Bug'#756
johbaxter merged 1 commit intodevfrom
755-members-page-search-pagination-bug

Conversation

@JoshRome26
Copy link
Copy Markdown
Contributor

Description

Edit limit in getUsers to match count, now we return all search results.

Changes Made

Edit limit in getUsers to match total user count.

How to Test

  1. Go to 'http://localhost:9090/SemossWeb/packages/client/dist/#'

  2. Click on 'Admin Page'

  3. Scroll down to and select 'Members Settings'

  4. Select '25' for 'RowsPerPage' dropdown

  5. Add 26 Users (UserId1 - UserId26)

  6. Returns 26 results.

  7. See the 1 - 25, need to use pagination to see result 26.

@JoshRome26 JoshRome26 requested a review from a team as a code owner March 25, 2025 17:33
@JoshRome26 JoshRome26 linked an issue Mar 25, 2025 that may be closed by this pull request
4 tasks
@JoshRome26 JoshRome26 self-assigned this Mar 25, 2025
@JoshRome26 JoshRome26 added the Bug Something isn't working label Mar 25, 2025
@github-actions
Copy link
Copy Markdown

@CodiumAI-Agent /describe

@QodoAI-Agent
Copy link
Copy Markdown

Title

Resolve 'Members Page Search Pagination Bug'


User description

Description

Edit limit in getUsers to match count, now we return all search results.

Changes Made

Edit limit in getUsers to match total user count.

How to Test

  1. Go to 'http://localhost:9090/SemossWeb/packages/client/dist/#'

  2. Click on 'Admin Page'

  3. Scroll down to and select 'Members Settings'

  4. Select '25' for 'RowsPerPage' dropdown

  5. Add 26 Users (UserId1 - UserId26)

  6. Returns 26 results.

  7. See the 1 - 25, need to use pagination to see result 26.


PR Type

Bug fix


Description

  • Adjust getUsers call to match full user count

  • Replace rowsPerPage with count for accurate pagination


Changes walkthrough 📝

Relevant files
Bug fix
UserTable.tsx
Use count instead of rowsPerPage for limit                             

packages/client/src/components/settings/UserTable.tsx

  • Changed limit parameter from rowsPerPage to count
+1/-1     

Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @github-actions
    Copy link
    Copy Markdown

    @CodiumAI-Agent /review

    @QodoAI-Agent
    Copy link
    Copy Markdown

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Undefined Variable

    The new code introduces count as the limit value. Please verify that count is properly defined in the component’s scope and that it carries the intended properties needed to fetch all search results.

    count, // limit

    @github-actions
    Copy link
    Copy Markdown

    @CodiumAI-Agent /improve

    @QodoAI-Agent
    Copy link
    Copy Markdown

    QodoAI-Agent commented Mar 25, 2025

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Validate pagination limit consistency

    Verify that count correctly represents the intended pagination limit and is updated
    consistently, ensuring it aligns with user settings.

    packages/client/src/components/settings/UserTable.tsx [235]

    -+        count, // limit
    ++        count, // limit (ensure `count` matches the expected rows per page setting)
    Suggestion importance[1-10]: 4

    __

    Why: The suggestion is advisory, asking verification of whether count properly represents the intended pagination limit. While ensuring consistency is useful, the change merely adds an explanatory comment, yielding a minor impact on overall functionality.

    Low

    @roxyramos
    Copy link
    Copy Markdown

    @QodoAI-Agent
    Copy link
    Copy Markdown

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Validate pagination limit consistency

    Verify that count correctly represents the intended pagination limit and is updated
    consistently, ensuring it aligns with user settings.

    packages/client/src/components/settings/UserTable.tsx [235]

    -+        count, // limit
    ++        count, // limit (ensure `count` matches the expected rows per page setting)
    Suggestion importance[1-10]: 4

    __

    Why: The suggestion is advisory, asking verification of whether count properly represents the intended pagination limit. While ensuring consistency is useful, the change merely adds an explanatory comment, yielding a minor impact on overall functionality.

    Low

    Copy link
    Copy Markdown
    Contributor

    @johbaxter johbaxter left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Ty

    @johbaxter johbaxter merged commit f292684 into dev Apr 4, 2025
    4 checks passed
    @johbaxter johbaxter deleted the 755-members-page-search-pagination-bug branch April 4, 2025 19:39
    @github-actions
    Copy link
    Copy Markdown

    github-actions bot commented Apr 4, 2025

    @CodiumAI-Agent /update_changelog

    @QodoAI-Agent
    Copy link
    Copy Markdown

    Changelog updates: 🔄

    2025-04-04

    Fixed

    • Resolved pagination issue in the members search, ensuring all results are returned.

    to commit the new content to the CHANGELOG.md file, please type:
    '/update_changelog --pr_update_changelog.push_changelog_changes=true'

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Bug Something isn't working

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    Members Page: Search Pagination Bug

    5 participants