You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The new code introduces count as the limit value. Please verify that count is properly defined in the component’s scope and that it carries the intended properties needed to fetch all search results.
-+ count, // limit++ count, // limit (ensure `count` matches the expected rows per page setting)
Suggestion importance[1-10]: 4
__
Why: The suggestion is advisory, asking verification of whether count properly represents the intended pagination limit. While ensuring consistency is useful, the change merely adds an explanatory comment, yielding a minor impact on overall functionality.
-+ count, // limit++ count, // limit (ensure `count` matches the expected rows per page setting)
Suggestion importance[1-10]: 4
__
Why: The suggestion is advisory, asking verification of whether count properly represents the intended pagination limit. While ensuring consistency is useful, the change merely adds an explanatory comment, yielding a minor impact on overall functionality.
Resolved pagination issue in the members search, ensuring all results are returned.
to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Edit limit in getUsers to match count, now we return all search results.
Changes Made
Edit limit in getUsers to match total user count.
How to Test
Go to 'http://localhost:9090/SemossWeb/packages/client/dist/#'
Click on 'Admin Page'
Scroll down to and select 'Members Settings'
Select '25' for 'RowsPerPage' dropdown
Add 26 Users (UserId1 - UserId26)
Returns 26 results.
See the 1 - 25, need to use pagination to see result 26.