Skip to content

feat(client): font settings popup interference fix#820

Merged
johbaxter merged 2 commits intodevfrom
794-FontSettings-popup-interference-fix
Apr 14, 2025
Merged

feat(client): font settings popup interference fix#820
johbaxter merged 2 commits intodevfrom
794-FontSettings-popup-interference-fix

Conversation

@Paulson-Robert
Copy link
Copy Markdown
Contributor

Description

Changes Made

How to Test

  1. Steps to reproduce/test the behavior
  2. Expected outcomes

Notes

@Paulson-Robert Paulson-Robert self-assigned this Apr 10, 2025
@Paulson-Robert Paulson-Robert requested a review from a team as a code owner April 10, 2025 09:40
@github-actions
Copy link
Copy Markdown

@CodiumAI-Agent /describe

@QodoAI-Agent
Copy link
Copy Markdown

Title

feat(client): font settings popup interference fix


User description

Description

Changes Made

How to Test

  1. Steps to reproduce/test the behavior
  2. Expected outcomes

Notes


PR Type

  • Enhancement

Description

  • Adjust BlockSettingsMask container padding and sizing.

  • Remove redundant constants and sizing in TextSettingsMask.


Changes walkthrough 📝

Relevant files
Enhancement
BlockSettingsMask.tsx
Adjust container styling for interference fix.                     

packages/client/src/components/designer/BlockSettingsMask.tsx

  • Updated padding from theme.spacing(2) to theme.spacing(1, 0, 0, 2).
  • Added maxWidth and minWidth properties using
    STYLED_FONT_STYLE_INPUT_WIDTH and STYLED_FONT_SIZE_INPUT_WIDTH.
  • +5/-1     
    TextSettingsMask.tsx
    Remove unused styling constants and sizing.                           

    packages/client/src/components/designer/settings-mask/TextSettingsMask.tsx

  • Removed constants: STYLED_FONT_STYLE_INPUT_WIDTH and
    STYLED_FONT_SIZE_INPUT_WIDTH.
  • Removed maxWidth and minWidth styling from StyledInputContainer.
  • +0/-7     

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @github-actions
    Copy link
    Copy Markdown

    @CodiumAI-Agent /review

    @github-actions
    Copy link
    Copy Markdown

    @CodiumAI-Agent /improve

    @QodoAI-Agent
    Copy link
    Copy Markdown

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Undefined Variable

    The new maxWidth computation uses STYLED_FONT_STYLE_INPUT_WIDTH, which is not declared in this diff. Verify that it is defined elsewhere or consider adding its declaration.

    maxWidth: `${
        STYLED_FONT_STYLE_INPUT_WIDTH + STYLED_FONT_SIZE_INPUT_WIDTH
    }px`,
    Layout Consistency

    The removal of width constraints in the styled container could impact layout consistency. Confirm that these changes align with the design intent.

    gap: '8px',
    boxShadow:
        '0px 5px 22px 0px rgba(0, 0, 0, 0.10), 0px 4px 4px 0.5px rgba(0, 0, 0, 0.03)',
    backgroundColor: 'white',
    padding: theme.spacing(1),
    borderRadius: theme.shape.borderRadius,

    @QodoAI-Agent
    Copy link
    Copy Markdown

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Eliminate whitespace in template

    Remove the multiline formatting in the template literal to avoid unintentional
    whitespace in the computed CSS value.

    packages/client/src/components/designer/BlockSettingsMask.tsx [23-25]

    -maxWidth: `${
    -    STYLED_FONT_STYLE_INPUT_WIDTH + STYLED_FONT_SIZE_INPUT_WIDTH
    -}px`,
    +maxWidth: `${STYLED_FONT_STYLE_INPUT_WIDTH + STYLED_FONT_SIZE_INPUT_WIDTH}px`,
    Suggestion importance[1-10]: 6

    __

    Why: The suggestion removes unnecessary newline and whitespace in the computed CSS value, which can prevent subtle formatting issues. However, it's a minor style improvement rather than a correction of a critical bug.

    Low

    @ehynd ehynd linked an issue Apr 10, 2025 that may be closed by this pull request
    @johbaxter
    Copy link
    Copy Markdown
    Contributor

    Thank you @Paulson-Robert

    @QodoAI-Agent
    Copy link
    Copy Markdown

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @johbaxter johbaxter merged commit dabe681 into dev Apr 14, 2025
    3 checks passed
    @johbaxter johbaxter deleted the 794-FontSettings-popup-interference-fix branch April 14, 2025 20:05
    @github-actions
    Copy link
    Copy Markdown

    @CodiumAI-Agent /update_changelog

    @QodoAI-Agent
    Copy link
    Copy Markdown

    Changelog updates: 🔄

    2025-04-14

    Fixed

    • Resolved interference issues in the font settings popup.

    to commit the new content to the CHANGELOG.md file, please type:
    '/update_changelog --pr_update_changelog.push_changelog_changes=true'

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    Font style and size popup interferes with selecting blocks below it

    3 participants