Skip to content

Remove dead code in client#884

Merged
johbaxter merged 6 commits intodevfrom
remove-dead-renderer-code-in-client
Apr 15, 2025
Merged

Remove dead code in client#884
johbaxter merged 6 commits intodevfrom
remove-dead-renderer-code-in-client

Conversation

@johbaxter
Copy link
Copy Markdown
Contributor

This should help with build times a little

@johbaxter johbaxter requested a review from a team as a code owner April 14, 2025 20:37
@github-actions
Copy link
Copy Markdown

@CodiumAI-Agent /describe

@QodoAI-Agent
Copy link
Copy Markdown

Title

Remove dead code in client


User description

This should help with build times a little


PR Type

  • Enhancement

Description

  • Clean up code formatting across multiple renderer files.

  • Standardize import syntax and add missing semicolons.

  • Refactor iteration block parsing and LLM context types.

  • Tweak UI layout margins and container sizing in client.


Changes walkthrough 📝

Relevant files
Enhancement
12 files
index.ts
Reformat and standardize iteration block imports.               
+4/-1     
IterationBlock.tsx
Add semicolons and improve iteration block formatting.     
+8/-8     
config.tsx
Refactor import formatting and styleMenu configuration.   
+19/-10 
index.ts
Standardize exports for iteration block components.           
+2/-2     
LLMComparisonContext.tsx
Update handleSubmit generics for improved type safety.     
+4/-1     
ChildBlockSettings.tsx
Improve formatting and adjust code style in child block settings.
+29/-21 
index.ts
Tidy up export formatting for custom block settings.         
+1/-1     
useBlock.tsx
Adjust parseVariable formatting for iteration blocks.       
+4/-1     
cell.state.ts
Reformat conditional checks with consistent semicolon usage.
+5/-2     
state.store.ts
Refine parseVariable logic and iterator descendant processing.
+40/-35 
BlockSettingsMask.tsx
Update padding and container sizing for designer mask.     
+5/-1     
TextSettingsMask.tsx
Revise font input container styling and remove unused constants.
+0/-7     

Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @github-actions
    Copy link
    Copy Markdown

    @CodiumAI-Agent /review

    @QodoAI-Agent
    Copy link
    Copy Markdown

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Regex Safety

    The new parseVariable logic uses a regex match and immediately accesses the match result. It would be safer to check that the match exists to avoid potential runtime errors when the expected pattern does not match.

    const variable = expression.match(/\$(.*?)\./)[1];
    const stripped = iteratorList.slice(2, -2);
    
    // TODO: how do we handle nested loops $array.warehouse.warehouseSections
    // Do we just call this recursively
    if (variable === stripped) {
        const path = expression.split(".").splice(1);
        const test = path.join(".");
        const val = getValueByPath(list[index], test);
    Undefined Variable

    The new style definition references STYLED_FONT_STYLE_INPUT_WIDTH without a corresponding declaration. This might lead to runtime errors or unexpected layout behavior.

        maxWidth: `${
            STYLED_FONT_STYLE_INPUT_WIDTH + STYLED_FONT_SIZE_INPUT_WIDTH
        }px`,
        minWidth: 'fit-content',
    }));

    @github-actions
    Copy link
    Copy Markdown

    @CodiumAI-Agent /improve

    @QodoAI-Agent
    Copy link
    Copy Markdown

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @johbaxter johbaxter merged commit 384f836 into dev Apr 15, 2025
    3 checks passed
    @johbaxter johbaxter deleted the remove-dead-renderer-code-in-client branch April 15, 2025 16:52
    @github-actions
    Copy link
    Copy Markdown

    @CodiumAI-Agent /update_changelog

    @QodoAI-Agent
    Copy link
    Copy Markdown

    Changelog updates: 🔄

    2025-04-15

    • Removed dead client code and improved code formatting and linting.

    to commit the new content to the CHANGELOG.md file, please type:
    '/update_changelog --pr_update_changelog.push_changelog_changes=true'

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants