Skip to content

feat(client): applied dense style for notebook table#992

Merged
johbaxter merged 3 commits intodevfrom
238-muiDense-NotebookDataTables
Apr 29, 2025
Merged

feat(client): applied dense style for notebook table#992
johbaxter merged 3 commits intodevfrom
238-muiDense-NotebookDataTables

Conversation

@Paulson-Robert
Copy link
Copy Markdown
Contributor

Description

Changes Made

How to Test

  1. Steps to reproduce/test the behavior
  2. Expected outcomes

Notes

@Paulson-Robert Paulson-Robert self-assigned this Apr 25, 2025
@Paulson-Robert Paulson-Robert requested a review from a team as a code owner April 25, 2025 14:44
@github-actions
Copy link
Copy Markdown

@CodiumAI-Agent /describe

@QodoAI-Agent
Copy link
Copy Markdown

Title

feat(client): applied dense style for notebook table


User description

Description

Changes Made

How to Test

  1. Steps to reproduce/test the behavior
  2. Expected outcomes

Notes


PR Type

Enhancement


Description

  • Add dense layout to notebook tables

  • Set size="small" prop on Table


Changes walkthrough 📝

Relevant files
Enhancement
FrameOperation.tsx
Enable dense table style                                                                 

packages/client/src/components/notebook/operations/FrameOperation.tsx

  • Added size="small" prop to <Table> component
+1/-1     

Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @github-actions
    Copy link
    Copy Markdown

    @CodiumAI-Agent /review

    @Paulson-Robert Paulson-Robert linked an issue Apr 25, 2025 that may be closed by this pull request
    @QodoAI-Agent
    Copy link
    Copy Markdown

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Component Prop Support

    Verify that the Table component accepts the size="small" prop and applies the expected dense styling without side effects.

    <Table stickyHeader size="small">
    UI Consistency

    Ensure the dense table styling matches other notebooks and remains readable across different screen sizes and themes.

    <Table stickyHeader size="small">
        <Table.Head>

    @github-actions
    Copy link
    Copy Markdown

    @CodiumAI-Agent /improve

    @QodoAI-Agent
    Copy link
    Copy Markdown

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @johbaxter
    Copy link
    Copy Markdown
    Contributor

    We need to decouple notebook just created a ticket for it. Duplicate FrameOperation components

    1 similar comment
    @johbaxter
    Copy link
    Copy Markdown
    Contributor

    We need to decouple notebook just created a ticket for it. Duplicate FrameOperation components

    @QodoAI-Agent
    Copy link
    Copy Markdown

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @johbaxter johbaxter merged commit b826301 into dev Apr 29, 2025
    3 checks passed
    @johbaxter johbaxter deleted the 238-muiDense-NotebookDataTables branch April 29, 2025 19:20
    @github-actions
    Copy link
    Copy Markdown

    @CodiumAI-Agent /update_changelog

    @QodoAI-Agent
    Copy link
    Copy Markdown

    Changelog updates: 🔄

    2025-04-29 #992

    Changed

    • Applied dense styling to notebook data tables in the client.

    to commit the new content to the CHANGELOG.md file, please type:
    '/update_changelog --pr_update_changelog.push_changelog_changes=true'

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    Use a MUI's dense property on data tables

    3 participants