changes to speed up website#146
Closed
johnrieth-zz wants to merge 1 commit intoSFPC:masterfrom
johnrieth-zz:fonts
Closed
changes to speed up website#146johnrieth-zz wants to merge 1 commit intoSFPC:masterfrom johnrieth-zz:fonts
johnrieth-zz wants to merge 1 commit intoSFPC:masterfrom
johnrieth-zz:fonts
Conversation
johnrieth-zz
changed the title
Member
|
thanks for catching this and making this PR ! sorry for the slow response. I was just wondering if our DNS was bad or something and this PR helped highlight the failing css call. we were using font deck for the logo which was in a specific font. If I give you the SFPC logo as svg do you think you can add it to this PR ? I can give it a shot also... thanks again! |
Author
|
Hey, no worries. Yes if you give me the SFPC logo as an svg I can add to the PR. |
Member
|
so sorry for the delay - been traveling! not sure why you closed this but please note that we are quite happy to take this PR ! cc @tchoi8 can you help with an SVG of the SFPC logo in apercu ? I think this PR would be great to have and we just need to get the logo in... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good morning,
I have gotten rid of the stylesheet from fontdeck since fontdeck has shutdown. Doing so should make the site load faster. I also upgraded jquery to the most recent version and the site is no longer fetching jquery from a cdn. The javascript source tags are at the bottom of default.html which you may want to change. I put the tags at the bottom because that is what I am used to doing.
I updated the _config.yml file to use plugins instead of gems. I got a warning that gems is deprecated and plugins is current way to load gems.