Restructured to have reference JSON directory#541
Merged
dr-rodriguez merged 4 commits intoSIMPLE-AstroDB:mainfrom Aug 13, 2024
Merged
Restructured to have reference JSON directory#541dr-rodriguez merged 4 commits intoSIMPLE-AstroDB:mainfrom
dr-rodriguez merged 4 commits intoSIMPLE-AstroDB:mainfrom
Conversation
Collaborator
Author
|
I noticed that github will suppress anything over 3000 files, but this particular PR is relatively simple as it is just moving data from the top-level data directory into data/source and data/reference. Once astrodbkit2 is updated, we can re-run the tests and confirm everything is working well (locally on my machine all tests pass with the new astrodbkit2). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructured the database with the changes from astrodbtoolkit/AstrodbKit#77
The tests are likely to fail until that gets merged and released.
The core change is that the
reference_directoryis now an optional variable that can be set (defaults to "reference") when saving/loading the database. Anything set as a reference table will get stored in that sub-directory. This is backwards compatible in the sense that if the reference tables are not in that directory, it will check the original (parent) directory.