Skip to content

Update __init__.py#35

Closed
y-luis-rojo wants to merge 1 commit into
SIPp:masterfrom
y-luis-rojo:patch-1
Closed

Update __init__.py#35
y-luis-rojo wants to merge 1 commit into
SIPp:masterfrom
y-luis-rojo:patch-1

Conversation

@y-luis-rojo
Copy link
Copy Markdown
Contributor

@y-luis-rojo y-luis-rojo commented Jul 25, 2018

When dirpath and proxyaddr are set, the last is ignored because of its indentation.

@y-luis-rojo
Update __init__.py
e95d3da 
When `dirpath` and `proxyaddr` are set, the last is ignored because of its indentation.
@y-luis-rojo y-luis-rojo mentioned this pull request Jul 25, 2018
Closed
goodboy
goodboy requested changes Jul 26, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@goodboy goodboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @y-luis!
Would you mind adding a test for this.
We also need to figured out why the SIPp build script is failing in CI.

@goodboy
Copy link
Copy Markdown
Member

goodboy commented Jul 27, 2018

@y-luis rebase this onto master and add a test if you don't mind.
We'll try to get the clean build in this PR.

@goodboy
Copy link
Copy Markdown
Member

goodboy commented Oct 12, 2018

@y-luis wait this was never merged?
I think this turns out to be the issue in #39.

@goodboy goodboy mentioned this pull request Oct 12, 2018
Open
@y-luis-rojo
Copy link
Copy Markdown
Contributor Author

y-luis-rojo commented Oct 12, 2018

@tgoodlet, no, it was never merged, I think you are right, it may be related with #39, but I did not had the opportunity to test it.

I realized I renamed the fork, and now this PR shows unknown repository, I am not sure a merge would work, if not, let me know and will create a new PR referencing this one.

@goodboy
Copy link
Copy Markdown
Member

goodboy commented Oct 12, 2018

@y-luis I wrote a test last night and added your fix (since we need both).

Surprisingly, at least for me, it doesn't solve #39...
I'm digging into this morning hopefully.

goodboy pushed a commit that referenced this pull request Oct 12, 2018
Fix #36
685735f 
Thanks to @y-luis for originally finding and fixing this problem.
The original PR (#35) was discarded accidentally.
@goodboy goodboy mentioned this pull request Oct 12, 2018
Merged
goodboy pushed a commit that referenced this pull request Jul 4, 2019
@goodboy
Fix #36
16bca29 
Thanks to @y-luis for originally finding and fixing this problem.
The original PR (#35) was discarded accidentally.
goodboy pushed a commit that referenced this pull request Jul 4, 2019
@goodboy
Fix #36
79b7534 
Thanks to @y-luis for originally finding and fixing this problem.
The original PR (#35) was discarded accidentally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goodboy goodboy goodboy requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@y-luis-rojo @goodboy